tools/auto_bisect/bisect_results.py - Issue 697713003: Aborting bisect early when the bug specified in the bisect config is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/auto_bisect/bisect_results.py

Issue 697713003: Aborting bisect early when the bug specified in the bisect config is closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing type=str since it's the default and rebasing Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/auto_bisect/bisect_results.py

diff --git a/tools/auto_bisect/bisect_results.py b/tools/auto_bisect/bisect_results.py

index 6a7c6e354aa069b123e0f247753e3ffc61ed751f..df93de6799577b361816e83bc3cf736d2a1ac55c 100644

--- a/tools/auto_bisect/bisect_results.py

+++ b/tools/auto_bisect/bisect_results.py

@@ -38,7 +38,7 @@ class BisectResults(object):

"""

def __init__(self, bisect_state=None, depot_registry=None, opts=None,

- runtime_warnings=None, error=None):

+ runtime_warnings=None, error=None, abort_reason=None):

"""Computes final bisect results after a bisect run is complete.

This constructor should be called in one of the following ways:

@@ -58,7 +58,8 @@ class BisectResults(object):

"""

self.error = error

- if error is not None:

+ self.abort_reason = abort_reason

+ if error is not None or abort_reason is not None:

return

assert (bisect_state is not None and depot_registry is not None and

« no previous file with comments | « tools/auto_bisect/bisect_printer.py ('k') | tools/auto_bisect/query_crbug.py » ('j') | no next file with comments »