Aborting bisect early when the bug specified in the bisect config is closed.

tools/run-bisect-perf-regression.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Run Performance Test Bisect Tool
 
 This script is used by a try bot to run the bisect script with the parameters
 specified in the bisect config file. It checks out a copy of the depot in
 a subdirectory 'bisect' of the working directory provided, annd runs the
@@ skipping 93 matching lines @@
     local_vars = {}
     execfile(config_file_path, local_vars)
     return local_vars['config']
   except Exception:
     print
     traceback.print_exc()
     print
     return {}
 
 
-def _ValidateConfigFile(config_contents, valid_parameters):
+def _ValidateConfigFile(config_contents, required_parameters):
   """Validates the config file contents, checking whether all values are
   non-empty.
 
   Args:
     config_contents: A config dictionary.
-    valid_parameters: A list of parameters to check for.
+    required_parameters: A list of parameters to check for.
 
   Returns:
     True if valid.
   """
-  for parameter in valid_parameters:
+  for parameter in required_parameters:
     if parameter not in config_contents:
       return False
     value = config_contents[parameter]
     if not value or type(value) is not str:
       return False
   return True
 
 
 def _ValidatePerfConfigFile(config_contents):
   """Validates the perf config file contents.
 
   This is used when we're doing a perf try job, rather than a bisect.
   The config file is called run-perf-test.cfg by default.
 
   The parameters checked are the required parameters; any additional optional
   parameters won't be checked and validation will still pass.
 
   Args:
     config_contents: A config dictionary.
 
   Returns:
     True if valid.
   """
-  valid_parameters = [
+  required_parameters = [
       'command',
       'repeat_count',
       'truncate_percent',
       'max_time_minutes',
   ]
-  return _ValidateConfigFile(config_contents, valid_parameters)
+  return _ValidateConfigFile(config_contents, required_parameters)
 
 
 def _ValidateBisectConfigFile(config_contents):
   """Validates the bisect config file contents.
 
   The parameters checked are the required parameters; any additional optional
   parameters won't be checked and validation will still pass.
 
   Args:
     config_contents: A config dictionary.
 
   Returns:
     True if valid.
   """
-  valid_params = [
+  required_params = [
       'command',
       'good_revision',
       'bad_revision',
       'metric',
       'repeat_count',
       'truncate_percent',
       'max_time_minutes',
   ]
-  return _ValidateConfigFile(config_contents, valid_params)
+  return _ValidateConfigFile(config_contents, required_params)
 
 
 def _OutputFailedResults(text_to_print):
   bisect_utils.OutputAnnotationStepStart('Results - Failed')
   print
   print text_to_print
   print
   bisect_utils.OutputAnnotationStepClosed()
 
 
@@ skipping 13 matching lines @@
     opts_dict['max_time_minutes'] = int(config['max_time_minutes'])
 
   if config.has_key('use_goma'):
     opts_dict['use_goma'] = config['use_goma']
   if config.has_key('goma_dir'):
     opts_dict['goma_dir'] = config['goma_dir']
 
   if config.has_key('improvement_direction'):
     opts_dict['improvement_direction'] = int(config['improvement_direction'])
 
+  if config.has_key('bug_id') and str(config['bug_id']).isdigit():
+    opts_dict['bug_id'] = config['bug_id']
+
   opts_dict['build_preference'] = 'ninja'
   opts_dict['output_buildbot_annotations'] = True
 
   if '--browser=cros' in config['command']:
     opts_dict['target_platform'] = 'cros'
 
     if os.environ[CROS_BOARD_ENV] and os.environ[CROS_IP_ENV]:
       opts_dict['cros_board'] = os.environ[CROS_BOARD_ENV]
       opts_dict['cros_remote_ip'] = os.environ[CROS_IP_ENV]
     else:
@@ skipping 179 matching lines @@
 
   if config['max_time_minutes']:
     cmd.extend(['--max_time_minutes', config['max_time_minutes']])
 
   if config.has_key('bisect_mode'):
     cmd.extend(['--bisect_mode', config['bisect_mode']])
 
   if config.has_key('improvement_direction'):
     cmd.extend(['-d', config['improvement_direction']])
 
+  if config.has_key('bug_id'):
+    cmd.extend(['--bug_id', config['bug_id']])
+
   cmd.extend(['--build_preference', 'ninja'])
 
   if '--browser=cros' in config['command']:
     cmd.extend(['--target_platform', 'cros'])
 
     if os.environ[CROS_BOARD_ENV] and os.environ[CROS_IP_ENV]:
       cmd.extend(['--cros_board', os.environ[CROS_BOARD_ENV]])
       cmd.extend(['--cros_remote_ip', os.environ[CROS_IP_ENV]])
     else:
       print ('Error: Cros build selected, but BISECT_CROS_IP or'
@@ skipping 141 matching lines @@
     if config and config_is_valid:
       return _SetupAndRunPerformanceTest(config, opts.path_to_goma)
 
   print ('Error: Could not load config file. Double check your changes to '
          'auto_bisect/bisect.cfg or run-perf-test.cfg for syntax errors.\n')
   return 1
 
 
 if __name__ == '__main__':
   sys.exit(main())