Issue 697713002: Remove line breaking to avoid window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 697713002: Remove line breaking to avoid window. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Remove line breaking to avoid window. Now that we don't have multi-column or pagination, this is dead code. This also means we don't need to call layoutBlockFlow in a loop. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dd227380d886885e7a9848872276f51795920358

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -66 lines)			Patch
M	sky/engine/core/rendering/RenderBlockFlow.h	View	4 chunks	+1 line, -14 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlockFlow.cpp	View	5 chunks	+2 lines, -50 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlockLineLayout.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

ojan

6 years, 1 month ago (2014-10-31 19:41:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dd227380d886885e7a9848872276f51795920358 (presubmit successful).