Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 697693003: Add a UseCounter for when xml:base takes effect in Element.baseURI (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Add a UseCounter for when xml:base takes effect in Element.baseURI This is the only internal usage of xml:base. BUG=341854 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/dom/Element.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
6 years, 1 month ago (2014-10-31 23:05:06 UTC) #2
pdr.
On 2014/10/31 at 23:05:06, philipj wrote: > PTAL LGTM LGTM LGTM LGTM LGTM LGTM!
6 years, 1 month ago (2014-10-31 23:20:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697693003/1
6 years, 1 month ago (2014-10-31 23:20:48 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 00:10:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184763

Powered by Google App Engine
This is Rietveld 408576698