Source/core/rendering/RenderBlock.h - Issue 697653004: [CSS Grid Layout] Grid items must set a new formatting context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.h

Issue 697653004: [CSS Grid Layout] Grid items must set a new formatting context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Applied additional suggested changes. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-margins-not-collapse-expected.html ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBlock.h

diff --git a/Source/core/rendering/RenderBlock.h b/Source/core/rendering/RenderBlock.h

index d4e3bdbddda8b05ba4f7fa8e706b1bc90579fa6b..9609543902c729a3a7662a2dd540b39b31cfd473 100644

--- a/Source/core/rendering/RenderBlock.h

+++ b/Source/core/rendering/RenderBlock.h

@@ -445,7 +445,7 @@ protected:

enum PageBoundaryRule { ExcludePageBoundary, IncludePageBoundary };

LayoutUnit nextPageLogicalTop(LayoutUnit logicalOffset, PageBoundaryRule = ExcludePageBoundary) const;

- bool createsBlockFormattingContext() const;

+ bool createsNewFormattingContext() const;

public:

LayoutUnit pageLogicalHeightForOffset(LayoutUnit offset) const;