LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item-expected.html - Issue 697653004: [CSS Grid Layout] Grid items must set a new formatting context.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item-expected.html

Issue 697653004: [CSS Grid Layout] Grid items must set a new formatting context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Applied suggested changes. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item.html ('K') | « LayoutTests/fast/css-grid-layout/float-not-protruding-into-next-grid-item.html ('k') | LayoutTests/fast/css-grid-layout/grid-item-margins-not-collapse.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <link href="resources/grid.css" rel="stylesheet">

	5 <style>

	6 .cell {

	7 width: 50px;

	8 height: auto;

	9 min-height: 50px

	10 }

	11

	12 .invisibleFont {

	13 color: lime;

	14 }

	15

	16 .floatLeft {

	17 float: left;

	18 }

	19

	20 .clearLeft {

	21 clear: left;

	22 }

	23

	24 .floatChild {
	Manuel Rego 2014/11/12 14:11:53 This is not used in the this file, so it should be This is not used in the this file, so it should be removed. jfernandez 2014/11/12 14:23:39 Done. Show quoted text On 2014/11/12 14:11:53, Manuel Rego wrote: > This is not used in the this file, so it should be removed. Done.
	25 float: left;

	26 clear: both;

	27 }

	28

	29 .relative {

	30 position: relative;

	31 }

	32 </style>

	33 </head>

	34

	35 <body>

	36

	37 <div>This test checks that grid item sets a new formatting context for its conte nt, preventing any 'float' protruding content on the adjoining grid item.</div>

	38

	39 <div>

	40 <div class="cell relative floatLeft firstRowFirstColumn">

	41 <div>Float1</div>

	42 <div>Float2</div>

	43 <div>Float3</div>

	44 <div>Float4</div>

	45 </div>

	46 <div class="cell floatLeft firstRowSecondColumn">

	47 <div class="invisibleFont">Float1</div>

	48 <div class="invisibleFont">Float2</div>

	49 <div class="invisibleFont">Float3</div>

	50 <div class="invisibleFont">Float4</div>

	51 </div>

	52 <div class="cell floatLeft clearLeft secondRowFirstColumn"></div>

	53 <div class="cell floatLeft secondRowSecondColumn"></div>

	54 </div>

	55

	56 </body>

	57 </html>

OLD	NEW