LayoutTests/fast/css-grid-layout/grid-item-margins-not-collapse.html - Issue 697653004: [CSS Grid Layout] Grid items must set a new formatting context.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-item-margins-not-collapse.html

Issue 697653004: [CSS Grid Layout] Grid items must set a new formatting context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <link href="resources/grid.css" rel="stylesheet">

	3
	Manuel Rego 2014/11/11 13:54:22 Probably it would be nice to add some kind of desc Probably it would be nice to add some kind of description text to the test. Julien - ping for review 2014/11/11 16:27:52 And a description of the expected output (what is Show quoted text On 2014/11/11 at 13:54:22, Manuel Rego wrote: > Probably it would be nice to add some kind of description > text to the test. And a description of the expected output (what is the condition for passing / failing?) jfernandez 2014/11/12 13:22:44 Done. Show quoted text On 2014/11/11 16:27:52, Julien Chaffraix - PST wrote: > On 2014/11/11 at 13:54:22, Manuel Rego wrote: > > Probably it would be nice to add some kind of description > > text to the test. > > And a description of the expected output (what is the condition for passing / > failing?) Done. jfernandez 2014/11/12 13:22:44 Done. Show quoted text On 2014/11/11 13:54:22, Manuel Rego wrote: > Probably it would be nice to add some kind of description > text to the test. Done.
	4 <div style="display: grid;">

	5 <div><p margin="20px 0px">XXXXX</p></div>

	6 <div style="margin:20px 0px;">XXXXX</div>

	7 <div><p margin="20px 0px">XXXXX</p></div>

	8 </div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-item-margins-not-collapse-expected.html » ('j') | Source/core/rendering/RenderBlock.cpp » ('J')