Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 697643003: Deterministic build: print the number of different bytes. (Closed)

Created:
6 years, 1 month ago by Sébastien Marchand
Modified:
6 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Deterministic build: print the number of different bytes. BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292768

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py View 1 3 chunks +30 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sébastien Marchand
PTAL. I'm not sure that this is the most efficient way to do this, and ...
6 years, 1 month ago (2014-10-31 17:18:46 UTC) #2
M-A Ruel
lgtm with nits https://codereview.chromium.org/697643003/diff/1/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py File scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py (right): https://codereview.chromium.org/697643003/diff/1/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py#newcode51 scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py:51: if lhs_data == '': if not ...
6 years, 1 month ago (2014-10-31 17:32:49 UTC) #3
Sébastien Marchand
Thanks, committing. https://codereview.chromium.org/697643003/diff/1/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py File scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py (right): https://codereview.chromium.org/697643003/diff/1/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py#newcode51 scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py:51: if lhs_data == '': On 2014/10/31 17:32:49, ...
6 years, 1 month ago (2014-10-31 17:48:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697643003/20001
6 years, 1 month ago (2014-10-31 17:48:32 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 17:49:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 292768

Powered by Google App Engine
This is Rietveld 408576698