Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 69763004: Define ARCH_CPU_LITTLE_ENDIAN for PNaCl (Closed)

Created:
7 years, 1 month ago by Sergey Ulanov
Modified:
7 years ago
Reviewers:
sehr, noelallen1
CC:
chromium-reviews
Visibility:
Public.

Description

Define ARCH_CPU_LITTLE_ENDIAN for PNaCl PNaCl bytecode is little-endian, but build_config.h didn't define ARCH_CPU_LITTLE_ENDIAN. BUG=276739 R=sehr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/build_config.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sergey Ulanov
7 years, 1 month ago (2013-11-14 00:30:40 UTC) #1
Sergey Ulanov
sehr1: ping
7 years, 1 month ago (2013-11-20 19:07:30 UTC) #2
Sergey Ulanov
+noelallen@ Noel, can you please review?
7 years ago (2013-11-25 18:28:37 UTC) #3
sehr
lgtm
7 years ago (2013-12-02 17:21:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/69763004/1
7 years ago (2013-12-02 18:13:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195377
7 years ago (2013-12-02 20:54:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/69763004/1
7 years ago (2013-12-02 21:09:39 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195606
7 years ago (2013-12-03 00:52:43 UTC) #8
Sergey Ulanov
7 years ago (2013-12-03 02:33:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r238276 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698