Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 69763003: Include <unistd.h> in base/process/internal_linux.h. (Closed)

Created:
7 years, 1 month ago by earthdok
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Include <unistd.h> in base/process/internal_linux.h. When building with libc++, this causes a build error due to missing definition for pid_t. BUG=318770 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/process/internal_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
earthdok
PTAL
7 years, 1 month ago (2013-11-13 14:50:23 UTC) #1
Nico
Please file a tracking bug for your libc++ work and link to it. With that, ...
7 years, 1 month ago (2013-11-13 14:53:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/69763003/1
7 years, 1 month ago (2013-11-13 15:59:51 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 19:19:03 UTC) #4
Message was sent while issue was closed.
Change committed as 234872

Powered by Google App Engine
This is Rietveld 408576698