content/browser/service_worker/embedded_worker_registry.h - Issue 697593002: ServiceWorker: Registering a malformed script should fail [2/3]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_registry.h

Issue 697593002: ServiceWorker: Registering a malformed script should fail [2/3] (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance_unittest.cc ('k') | content/browser/service_worker/embedded_worker_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_registry.h

diff --git a/content/browser/service_worker/embedded_worker_registry.h b/content/browser/service_worker/embedded_worker_registry.h

index 70613735582a205092e49e4c800ed3eb53542e5a..c18988281f5d29febfab066c6205fb9e5cf36714 100644

--- a/content/browser/service_worker/embedded_worker_registry.h

+++ b/content/browser/service_worker/embedded_worker_registry.h

@@ -56,9 +56,9 @@ class CONTENT_EXPORT EmbeddedWorkerRegistry

scoped_ptr<EmbeddedWorkerInstance> CreateWorker();

// Called from EmbeddedWorkerInstance, relayed to the child process.

- void SendStartWorker(scoped_ptr<EmbeddedWorkerMsg_StartWorker_Params> params,

- const StatusCallback& callback,

- int process_id);

+ ServiceWorkerStatusCode SendStartWorker(

+ scoped_ptr<EmbeddedWorkerMsg_StartWorker_Params> params,

+ int process_id);

ServiceWorkerStatusCode StopWorker(int process_id,

int embedded_worker_id);

@@ -72,6 +72,9 @@ class CONTENT_EXPORT EmbeddedWorkerRegistry

int thread_id,

int embedded_worker_id);

void OnWorkerScriptLoadFailed(int process_id, int embedded_worker_id);

+ void OnWorkerScriptEvaluated(int process_id,

+ int embedded_worker_id,

+ bool success);

void OnWorkerStarted(int process_id, int embedded_worker_id);

void OnWorkerStopped(int process_id, int embedded_worker_id);

void OnPausedAfterDownload(int process_id, int embedded_worker_id);