Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 697593002: ServiceWorker: Registering a malformed script should fail [2/3] (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index 26652dff2180cb833fd2aa50905b2a1d48c7133f..3eb9bda1c5f1c2a44dbc1b5f56ed481b50080b41 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -247,7 +247,14 @@ void EmbeddedWorkerInstance::SendStartWorker(
worker_devtools_agent_route_id_ = worker_devtools_agent_route_id;
params->worker_devtools_agent_route_id = worker_devtools_agent_route_id;
params->wait_for_debugger = wait_for_debugger;
- registry_->SendStartWorker(params.Pass(), callback, process_id_);
+ ServiceWorkerStatusCode status =
+ registry_->SendStartWorker(params.Pass(), process_id_);
+ if (status != SERVICE_WORKER_OK) {
+ callback.Run(status);
+ return;
+ }
+ DCHECK(start_callback_.is_null());
+ start_callback_ = callback;
}
void EmbeddedWorkerInstance::OnReadyForInspection() {
@@ -263,6 +270,13 @@ void EmbeddedWorkerInstance::OnScriptLoaded(int thread_id) {
void EmbeddedWorkerInstance::OnScriptLoadFailed() {
}
+void EmbeddedWorkerInstance::OnScriptEvaluated(bool success) {
+ DCHECK(!start_callback_.is_null());
+ start_callback_.Run(success ? SERVICE_WORKER_OK
+ : SERVICE_WORKER_ERROR_START_WORKER_FAILED);
+ start_callback_.Reset();
+}
+
void EmbeddedWorkerInstance::OnStarted() {
// Stop is requested before OnStarted is sent back from the worker.
if (status_ == STOPPING)
@@ -281,6 +295,7 @@ void EmbeddedWorkerInstance::OnStopped() {
process_id_ = -1;
thread_id_ = -1;
worker_devtools_agent_route_id_ = MSG_ROUTING_NONE;
+ start_callback_.Reset();
FOR_EACH_OBSERVER(Listener, listener_list_, OnStopped());
}

Powered by Google App Engine
This is Rietveld 408576698