Add turbocheck Makefile target.

Add turbocheck Makefile target.

The turbocheck target is similar to quickcheck, but runs only the
turbofan variant.

R=machenbach@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=25026

[Benedikt Meurer, 2014-10-31 06:41:57]

bmeurer@chromium.org changed reviewers:
+ machenbach@chromium.org

[Benedikt Meurer, 2014-10-31 06:41:58]

PTAL

[Michael Achenbach, 2014-10-31 08:08:03]

lgtm ~ suggestions:

https://codereview.chromium.org/697573002/diff/1/Makefile
File Makefile (right):

https://codereview.chromium.org/697573002/diff/1/Makefile#newcode260
Makefile:260: qc quickcheck $(QUICKCHECKS) turbocheck \
So, you only want one stand-alone turbocheck target that is not combinable with
modes and arches to e.g. write ia32.release.turbocheck?

https://codereview.chromium.org/697573002/diff/1/Makefile#newcode392
Makefile:392: --variants=turbofan --download-data mozilla webkit
You could keep --quickcheck in order to not run flaky, pass/fail and slow tests.
Not sure if that's what you want. The --variants flag overwrites the variants
set by quickcheck.

You could also pass explicitly --flaky-tests=skip or --pass-fail-tests=skip if
you only want some of them.

https://codereview.chromium.org/697573002/diff/1/Makefile#newcode395
Makefile:395: --variants=turbofan
For lazy typers?
tc: turbocheck

[Benedikt Meurer, 2014-10-31 08:38:45]

https://codereview.chromium.org/697573002/diff/1/Makefile
File Makefile (right):

https://codereview.chromium.org/697573002/diff/1/Makefile#newcode260
Makefile:260: qc quickcheck $(QUICKCHECKS) turbocheck \
Yes.

https://codereview.chromium.org/697573002/diff/1/Makefile#newcode392
Makefile:392: --variants=turbofan --download-data mozilla webkit
On 2014/10/31 08:08:02, Michael Achenbach wrote:
> You could keep --quickcheck in order to not run flaky, pass/fail and slow
tests.
> Not sure if that's what you want. The --variants flag overwrites the variants
> set by quickcheck.
> 
> You could also pass explicitly --flaky-tests=skip or --pass-fail-tests=skip if
> you only want some of them. 

Acknowledged.

https://codereview.chromium.org/697573002/diff/1/Makefile#newcode395
Makefile:395: --variants=turbofan
On 2014/10/31 08:08:02, Michael Achenbach wrote:
> For lazy typers?
> tc: turbocheck

Done.

[Benedikt Meurer, 2014-10-31 08:39:20]

Committed patchset #2 (id:20001) manually as 25026 (presubmit successful).