Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 697563003: DevTools: do not show compiled script while source maps are being loaded. (Closed)

Created:
6 years, 1 month ago by pfeldman
Modified:
6 years, 1 month ago
Reviewers:
vsevik, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: do not show compiled script while source maps are being loaded. BUG=424191 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184792

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : w/ tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -13 lines) Patch
M LayoutTests/http/tests/inspector/compiler-script-mapping.html View 1 2 4 chunks +24 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector/compiler-script-mapping-expected.txt View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/debugger-test.js View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/inspector/workspace-test.js View 1 2 4 chunks +12 lines, -4 lines 0 comments Download
M Source/devtools/front_end/bindings/CompilerScriptMapping.js View 1 6 chunks +29 lines, -1 line 0 comments Download
M Source/devtools/front_end/common/StaticContentProvider.js View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/UISourceCodeFrame.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/workspace/Workspace.js View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pfeldman
6 years, 1 month ago (2014-10-31 13:43:33 UTC) #2
pfeldman
6 years, 1 month ago (2014-10-31 13:45:13 UTC) #4
vsevik
lgtm
6 years, 1 month ago (2014-10-31 15:59:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697563003/40001
6 years, 1 month ago (2014-11-03 07:46:38 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 14:20:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184792

Powered by Google App Engine
This is Rietveld 408576698