Support transition between chrome and user mode console

chrome/browser/chromeos/dbus/console_service_provider.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_DBUS_CONSOLE_SERVICE_PROVIDER_H_
+#define CHROME_BROWSER_CHROMEOS_DBUS_CONSOLE_SERVICE_PROVIDER_H_
+
+#include <string>
+
+#include "base/bind.h"

[Daniel Erat, 2014/11/04 15:18:49]

you probably don't need this include here, right?

[dsodman, 2014/11/04 16:35:04]

Done.

+#include "base/memory/weak_ptr.h"
+#include "chrome/browser/chromeos/dbus/cros_dbus_service.h"
+#include "dbus/exported_object.h"
+#include "dbus/message.h"

[hashimoto, 2014/11/04 08:57:44]

nit: This include is not needed thanks to forward declarations?

[dsodman, 2014/11/04 16:35:04]

Done.

+
+namespace dbus {
+class MethodCall;
+class Response;

[Daniel Erat, 2014/11/04 15:18:50]

it doesn't look like this forward declaration is used

[dsodman, 2014/11/04 16:35:05]

Done.

+}
+
+namespace chromeos {
+
+// This class provides an api for external apps to notify

[Daniel Erat, 2014/11/04 15:18:49]

while we're providing comment nits: s/api/API/ on this line and s/chrome/Chrome/
on the next line

[dsodman, 2014/11/04 16:35:05]

Done.

+// chrome that it should release control of the display server.
+// The main client is the console application.   This can

[satorux1, 2014/11/04 06:42:30]

nit: three spaces -> one/two spaces?

[dsodman, 2014/11/04 16:35:05]

Done.

+// also be used by crouton to take over the display.
+class ConsoleServiceProvider
+    : public CrosDBusService::ServiceProviderInterface {
+ public:
+  ConsoleServiceProvider();
+  ~ConsoleServiceProvider() override;
+
+  // CrosDBusService::ServiceProviderInterface overrides:
+  void Start(scoped_refptr<dbus::ExportedObject> exported_object) override;
+
+ private:
+  // This method will get called when a external process no longer needs
+  // control of the display and chrome can take ownership.

[Daniel Erat, 2014/11/04 15:18:50]

nit: s/chrome/Chrome/

[dsodman, 2014/11/04 16:35:04]

Done.

+  void TakeDisplayOwnership(
+      dbus::MethodCall* method_call,
+      dbus::ExportedObject::ResponseSender response_sender);
+
+  // This method will get called when a external process needs control of
+  // the display server and needs chrome to release ownership.

[Daniel Erat, 2014/11/04 15:18:50]

nit: s/chrome/Chrome/, s/display server/display/ (unless there's a server that i
don't know about, in which case the TakeDisplayOwnership comment should probably
mention it too)

[dsodman, 2014/11/04 16:35:04]

Done.

+  void ReleaseDisplayOwnership(
+      dbus::MethodCall* method_call,
+      dbus::ExportedObject::ResponseSender response_sender);
+
+  // This method is called when a dbus method is exported.  If the export of the
+  // method is successful, |success| will be true.  It will be false
+  // otherwise.
+  void OnExported(const std::string& interface_name,
+                  const std::string& method_name,
+                  bool success);
+
+  base::WeakPtrFactory<ConsoleServiceProvider> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(ConsoleServiceProvider);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_DBUS_CONSOLE_SERVICE_PROVIDER_H_