Support transition between chrome and user mode console

chrome/browser/chromeos/dbus/console_service_provider.cc

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.

[Daniel Erat, 2014/11/01 13:57:44]

nit: remove "(c) "

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/dbus/console_service_provider.h"
+#include "third_party/cros_system_api/dbus/service_constants.h"
+
+namespace chromeos {
+
+ConsoleServiceProvider::ConsoleServiceProvider() : weak_ptr_factory_(this) {
+}
+
+ConsoleServiceProvider::~ConsoleServiceProvider() {
+}
+
+void ConsoleServiceProvider::AddObserver(Observer* observer) {
+  observers_.AddObserver(observer);
+}
+
+void ConsoleServiceProvider::RemoveObserver(Observer* observer) {
+  observers_.RemoveObserver(observer);
+}
+
+bool ConsoleServiceProvider::HasObserver(Observer* observer) {
+  return observers_.HasObserver(observer);
+}
+
+void ConsoleServiceProvider::Start(
+    scoped_refptr<dbus::ExportedObject> exported_object) {
+  exported_object->ExportMethod(
+      kLibCrosServiceInterface,
+      kActivateConsole,
+      base::Bind(&ConsoleServiceProvider::ActivateConsole,
+                 weak_ptr_factory_.GetWeakPtr()),
+      base::Bind(&ConsoleServiceProvider::OnExported,
+                 weak_ptr_factory_.GetWeakPtr()));
+}
+
+void ConsoleServiceProvider::ActivateConsole(
+    dbus::MethodCall* method_call,
+    dbus::ExportedObject::ResponseSender response_sender) {
+  dbus::MessageReader reader(method_call);
+  int console_id = 0;
+  if (reader.PopInt32(&console_id)) {
+    FOR_EACH_OBSERVER(Observer, observers_, OnActivateConsole(console_id));
+  } else {
+    LOG(ERROR) << "Unable to parse " << kActivateConsole << " request";
+  }
+
+  response_sender.Run(dbus::Response::FromMethodCall(method_call));
+}
+
+void ConsoleServiceProvider::OnExported(const std::string& interface_name,
+                                        const std::string& method_name,
+                                        bool success) {
+  if (!success) {

[Daniel Erat, 2014/11/01 13:57:44]

nit: omit curly brackets since the statement is a single line

+    LOG(ERROR) << "failed to export " << interface_name << "." << method_name;
+  }
+}
+
+}  // namespace chromeos