Issue 697473005: Pass indication of locally created typeface to SkCreateTypefaceFromCTFont

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 697473005: Pass indication of locally created typeface to SkCreateTypefaceFromCTFont (Closed)

Created:
6 years, 1 month ago by caseq

Modified:
6 years, 1 month ago

Reviewers:
Dominik Röttsches, bungeman-chromium, Stephen Chennney, reed2

CC:
blink-reviews, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Pass indication of locally created typeface to SkCreateTypefaceFromCTFont Skia needs to know whether the font may be located just by font name/family, or it needs to save the glyph data to be able to restore font later. This plumbs the indication of fonts that are dynamically loaded from FontCustomPlatformData down to SkCreateTypefaceFromCTFont(). BUG=426088

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -4 lines)			Patch
M	Source/platform/fonts/FontPlatformData.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/platform/fonts/FontPlatformData.cpp	View	7 chunks	+7 lines, -2 lines	0 comments	Download
M	Source/platform/fonts/mac/FontCustomPlatformDataMac.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/mac/FontPlatformDataMac.mm	View	4 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

caseq

6 years, 1 month ago (2014-11-06 22:52:42 UTC) #4

Message was sent while issue was closed.

Closing this, as alternative fix was landed
(https://codereview.chromium.org/691733004/)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages