Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: media/base/media_log.h

Issue 697463005: Add PipelineStatus UMA logging to media_internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing CL comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/media_log.h
diff --git a/media/base/media_log.h b/media/base/media_log.h
index f342ee84fc44185d8590c3ce5c6c2700a7904d45..7a7d541155939f000678d2ad0a2a1b1d530a7ee3 100644
--- a/media/base/media_log.h
+++ b/media/base/media_log.h
@@ -40,8 +40,9 @@ class MEDIA_EXPORT MediaLog : public base::RefCountedThreadSafe<MediaLog> {
public:
// Convert various enums to strings.
static const char* EventTypeToString(MediaLogEvent::Type type);
- static const char* PipelineStatusToString(PipelineStatus);
-
+ static const char* PipelineStatusToString(PipelineStatus status);
+ static bool StringToPipelineStatus(const std::string status,
+ PipelineStatus& out_status);
MediaLog();
// Add an event to this log. Overriden by inheritors to actually do something

Powered by Google App Engine
This is Rietveld 408576698