Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Unified Diff: content/browser/media/media_internals.h

Issue 697463005: Add PipelineStatus UMA logging to media_internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing CL comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/media/media_internals.cc » ('j') | content/browser/media/media_internals.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/media_internals.h
diff --git a/content/browser/media/media_internals.h b/content/browser/media/media_internals.h
index 4c1b2ed2ed6452e3554a12c3fc94d08c66a0ddc9..4095b6af0b20be01002ddc79a3ae62cbc1efdfa5 100644
--- a/content/browser/media/media_internals.h
+++ b/content/browser/media/media_internals.h
@@ -16,6 +16,7 @@
#include "base/values.h"
#include "content/common/content_export.h"
#include "media/audio/audio_logging.h"
+#include "media/base/media_log.h"
#include "media/video/capture/video_capture_device_info.h"
namespace media {
@@ -59,10 +60,15 @@ class CONTENT_EXPORT MediaInternals
scoped_ptr<media::AudioLog> CreateAudioLog(AudioComponent component) override;
private:
+ // Inner class to handle reporting pipelinestatus to UMA
+ class MediaInternalsUMAHandler;
+
friend class AudioLogImpl;
friend class MediaInternalsTest;
friend struct base::DefaultLazyInstanceTraits<MediaInternals>;
+ scoped_ptr<MediaInternalsUMAHandler> uma_handler;
DaleCurtis 2014/11/11 19:24:01 Needs underscore_ should be at the end of the clas
prabhur1 2014/11/12 21:32:37 Done.
+
MediaInternals();
// Sends |update| to each registered UpdateCallback. Safe to call from any
@@ -92,6 +98,6 @@ class CONTENT_EXPORT MediaInternals
DISALLOW_COPY_AND_ASSIGN(MediaInternals);
};
-} // namespace content
+} // namespace content
#endif // CONTENT_BROWSER_MEDIA_MEDIA_INTERNALS_H_
« no previous file with comments | « no previous file | content/browser/media/media_internals.cc » ('j') | content/browser/media/media_internals.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698