Add PipelineStatus UMA logging to media_internals

media/base/media_log.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/media_log.h"
 
 #include <string>
 
 #include "base/atomic_sequence_num.h"
 #include "base/logging.h"
@@ skipping 80 matching lines @@
       return "dumuxer: could not parse";
     case DEMUXER_ERROR_NO_SUPPORTED_STREAMS:
       return "demuxer: no supported streams";
     case DECODER_ERROR_NOT_SUPPORTED:
       return "decoder: not supported";
   }
   NOTREACHED();
   return NULL;
 }
 
+bool MediaLog::StringToPipelineStatus(const std::string& status,
+                                      PipelineStatus& out_status) {
+  static std::map<std::string, PipelineStatus> status_map = {

[DaleCurtis, 2014/11/06 23:49:08]

Instead just create a parallel array of strings which matches the pipelinestatus
codes and add a compile_assert() to ensure they stay in sync.  I.e. 

static const char* PlayerStatus[] = {
 "pipeline: ok",  // == PIPELINE_OK
 ...
};

You can then just iterate and return the right status code based on position.

[prabhur1, 2014/11/07 23:43:24]

Done.

+      {"pipeline: ok", PIPELINE_OK},
+      {"pipeline: url not found", PIPELINE_ERROR_URL_NOT_FOUND},
+      {"pipeline: network error", PIPELINE_ERROR_NETWORK},
+      {"pipeline: decode error", PIPELINE_ERROR_DECODE},
+      {"pipeline: decrypt error", PIPELINE_ERROR_DECRYPT},
+      {"pipeline: abort", PIPELINE_ERROR_ABORT},
+      {"pipeline: initialization failed", PIPELINE_ERROR_INITIALIZATION_FAILED},
+      {"pipeline: could not render", PIPELINE_ERROR_COULD_NOT_RENDER},
+      {"pipeline: read error", PIPELINE_ERROR_READ},
+      {"pipeline: operation pending", PIPELINE_ERROR_OPERATION_PENDING},
+      {"pipeline: invalid state", PIPELINE_ERROR_INVALID_STATE},
+      {"demuxer: could not open", DEMUXER_ERROR_COULD_NOT_OPEN},
+      {"dumuxer: could not parse", DEMUXER_ERROR_COULD_NOT_PARSE},
+      {"demuxer: no supported streams", DEMUXER_ERROR_NO_SUPPORTED_STREAMS},
+      {"decoder: not supported", DECODER_ERROR_NOT_SUPPORTED}};
+  auto it = status_map.find(status);
+  if (it != status_map.end()) {
+    out_status = status_map[status];
+    return true;
+  }
+  return false;
+}
+
 LogHelper::LogHelper(const LogCB& log_cb) : log_cb_(log_cb) {}
 
 LogHelper::~LogHelper() {
   if (log_cb_.is_null())
     return;
   log_cb_.Run(stream_.str());
 }
 
 MediaLog::MediaLog() : id_(g_media_log_count.GetNext()) {}
 
@@ skipping 120 matching lines @@
     const char* key, base::TimeDelta value) {
   scoped_ptr<MediaLogEvent> event(CreateEvent(MediaLogEvent::PROPERTY_CHANGE));
   if (value.is_max())
     event->params.SetString(key, "unknown");
   else
     event->params.SetDouble(key, value.InSecondsF());
   AddEvent(event.Pass());
 }
 
 }  //namespace media