Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 697463002: print preview: more voice feedback issues. (Closed)

Created:
6 years, 1 month ago by Dan Beam
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

print preview: more voice feedback issues. * Removes an image without [alt] from being spoken * Adds a label to summary (e.g. Printing: 1 sheet of paper.) * Removes "Loading preview..." from screen readers (hidden with opacity: 0 only) * Adds more info to the custom pages input ("e.g. 1-3, 5, 8-11") R=dmazzoni@chromium.org BUG=383955 Committed: https://crrev.com/1e5bccdca7ead7c5166d22613ff738acfd001037 Cr-Commit-Position: refs/heads/master@{#302226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/browser/resources/print_preview/common/search_box.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/previewarea/preview_area.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_header.js View 1 chunk +10 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/page_settings.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Dan Beam
6 years, 1 month ago (2014-10-31 02:26:14 UTC) #1
dmazzoni
lgtm
6 years, 1 month ago (2014-10-31 04:20:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697463002/1
6 years, 1 month ago (2014-10-31 04:20:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 05:01:34 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 05:02:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e5bccdca7ead7c5166d22613ff738acfd001037
Cr-Commit-Position: refs/heads/master@{#302226}

Powered by Google App Engine
This is Rietveld 408576698