Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issue 697373004: Moved StartPageForVectorCanvas from Metafile to PdfMetafileSkia. (Closed)

Created:
6 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Moved StartPageForVectorCanvas from Metafile to PdfMetafileSkia. Method is used only for PdfMetafileSkia. Committed: https://crrev.com/9de71ea970dda9c654e9c0db55d137f1b69731ce Cr-Commit-Position: refs/heads/master@{#302770}

Patch Set 1 #

Patch Set 2 : Tue Nov 4 10:41:42 PST 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -37 lines) Patch
M printing/emf_win.h View 1 chunk +0 lines, -3 lines 0 comments Download
M printing/emf_win.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M printing/metafile.h View 2 chunks +0 lines, -9 lines 0 comments Download
M printing/pdf_metafile_cg_mac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M printing/pdf_metafile_cg_mac.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M printing/pdf_metafile_skia.h View 1 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Vitaly Buka (NO REVIEWS)
6 years, 1 month ago (2014-11-04 18:55:35 UTC) #2
hal.canary
lgtm
6 years, 1 month ago (2014-11-04 23:09:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697373004/20001
6 years, 1 month ago (2014-11-04 23:14:06 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-04 23:14:08 UTC) #8
hal canary at chromium
lgtm
6 years, 1 month ago (2014-11-04 23:16:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697373004/20001
6 years, 1 month ago (2014-11-04 23:22:36 UTC) #11
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-04 23:22:48 UTC) #13
gene
lgtm
6 years, 1 month ago (2014-11-05 00:00:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697373004/20001
6 years, 1 month ago (2014-11-05 08:35:12 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 09:22:43 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 09:23:18 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9de71ea970dda9c654e9c0db55d137f1b69731ce
Cr-Commit-Position: refs/heads/master@{#302770}

Powered by Google App Engine
This is Rietveld 408576698