Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 697363002: Remove DOMImplementation. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium, ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove DOMImplementation. Expose a Document constructor instead. This also exposes that the TemplateBinding library might need more control over the registration context for custom elements. For now we make all documents share the same registration context. R=ojan@chromium.org, abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9db95006a8d2d4edaa1f018b04e9ebb812b72607

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -268 lines) Patch
M sky/engine/core/core.gni View 2 chunks +0 lines, -2 lines 0 comments Download
D sky/engine/core/dom/DOMImplementation.h View 1 chunk +0 lines, -67 lines 0 comments Download
D sky/engine/core/dom/DOMImplementation.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D sky/engine/core/dom/DOMImplementation.idl View 1 chunk +0 lines, -25 lines 0 comments Download
D sky/engine/core/dom/DOMImplementationTest.cpp View 1 chunk +0 lines, -68 lines 2 comments Download
M sky/engine/core/dom/Document.h View 4 chunks +3 lines, -5 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 3 chunks +7 lines, -8 lines 0 comments Download
M sky/engine/core/dom/Document.idl View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/framework/sky-element/TemplateBinding.sky View 1 chunk +3 lines, -1 line 0 comments Download
A + sky/tests/lowlevel/create-document.sky View 1 chunk +4 lines, -4 lines 0 comments Download
A sky/tests/lowlevel/create-document-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M sky/tests/lowlevel/createElement.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/tests/lowlevel/dom-implementation-create-document.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/tests/lowlevel/dom-implementation-create-document-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/tests/mutation-observer/cross-document.sky View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (1 generated)
ojan
lgtm https://codereview.chromium.org/697363002/diff/1/sky/engine/core/dom/DOMImplementationTest.cpp File sky/engine/core/dom/DOMImplementationTest.cpp (left): https://codereview.chromium.org/697363002/diff/1/sky/engine/core/dom/DOMImplementationTest.cpp#oldcode50 sky/engine/core/dom/DOMImplementationTest.cpp:50: EXPECT_TRUE(DOMImplementation::isTextMIMEType("application/x-javascript-like+json;a=2;c=4")); wat https://codereview.chromium.org/697363002/diff/1/sky/engine/core/dom/DOMImplementationTest.cpp#oldcode56 sky/engine/core/dom/DOMImplementationTest.cpp:56: EXPECT_TRUE(DOMImplementation::isTextMIMEType("application/x-what+json;")); Lol https://codereview.chromium.org/697363002/diff/1/sky/tests/mutation-observer/cross-document.sky File ...
6 years, 1 month ago (2014-11-04 07:15:47 UTC) #2
esprehn
6 years, 1 month ago (2014-11-04 07:18:44 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9db95006a8d2d4edaa1f018b04e9ebb812b72607.

Powered by Google App Engine
This is Rietveld 408576698