Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 697343002: Revert of Use a stub implementation of GlobalShortcutListener for Athena (Closed)

Created:
6 years, 1 month ago by tzik
Modified:
6 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@athena_do_not_use_ash47_media_stub
Project:
chromium
Visibility:
Public.

Description

Revert of Use a stub implementation of GlobalShortcutListener for Athena (patchset #3 id:100001 of https://codereview.chromium.org/697803002/) Reason for revert: This CL breaks GN build on ChromeOS: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20GN&number=187 The error message was: ERROR at //chrome/browser/extensions/BUILD.gn:189:7: Item not found "global_shortcut_listener_x11.cc", ^-------------------------------- You were trying to remove "global_shortcut_listener_x11.cc" from the list but it wasn't there. Original issue's description: > Use a stub implementation of GlobalShortcutListener for Athena > > BUG=426561 > TEST=None > > Committed: https://crrev.com/3064611cafd0464e4899dfdf7f485efe71f3ef57 > Cr-Commit-Position: refs/heads/master@{#302578} TBR=oshima@chromium.org,asargent@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=426561 Committed: https://crrev.com/0b7420d17a9fa360484ad1dc7fefe15e45f64edb Cr-Commit-Position: refs/heads/master@{#302580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -97 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/extensions/global_shortcut_listener_athena.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/extensions/global_shortcut_listener_athena.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 4 chunks +10 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tzik
Created Revert of Use a stub implementation of GlobalShortcutListener for Athena
6 years, 1 month ago (2014-11-04 06:20:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697343002/1
6 years, 1 month ago (2014-11-04 06:21:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 06:22:13 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 06:22:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b7420d17a9fa360484ad1dc7fefe15e45f64edb
Cr-Commit-Position: refs/heads/master@{#302580}

Powered by Google App Engine
This is Rietveld 408576698