Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 69723002: [sync] Fix behavior of "Use default settings" / "Advanced" links (Closed)

Created:
7 years, 1 month ago by Raghu Simha
Modified:
7 years, 1 month ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

[sync] Fix behavior of "Use default settings" / "Advanced" links This CL fixes the behavior seen while switching between the "Use default settings" / "Advanced" modes of the sync setup dialog. BUG=316547 TEST=Switch between the "Use default settings" and "Advanced" modes. OK button must receive focus. R=rogerta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/sync_setup_overlay.js View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Raghu Simha
Roger, please review. Thanks.
7 years, 1 month ago (2013-11-11 23:51:16 UTC) #1
Raghu Simha
Ping.
7 years, 1 month ago (2013-11-12 19:29:31 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
7 years, 1 month ago (2013-11-12 21:05:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsimha@chromium.org/69723002/1
7 years, 1 month ago (2013-11-12 21:11:43 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-12 22:07:19 UTC) #5
Raghu Simha
7 years, 1 month ago (2013-11-12 22:19:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r234650 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698