Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1886)

Unified Diff: build/common.gypi

Issue 697223003: MacViews: Get chrome/browser/ui/views/frame to compile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@constrained
Patch Set: Rebase. Add mac_views_browser build flag Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index b8a87e09c707e3b6bc7cf47fcd41bbcdd8499e9a..2cbff68cb29e89da8b7836af59033129ad0533e4 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -61,6 +61,9 @@
# Whether we are using Views Toolkit
'toolkit_views%': 0,
+ # Whether the browser is non-native (using Views Toolkit) on Mac.
+ 'mac_views_browser%': 0,
tapted 2014/11/04 02:33:42 nit: since other things don't depend on it, I thin
Andre 2014/11/05 02:04:22 Done.
+
# Use OpenSSL instead of NSS as the underlying SSL and crypto
# implementation. Certificate verification will in most cases be
# handled by the OS. If OpenSSL's struct X509 is used to represent
@@ -277,6 +280,7 @@
'target_subarch%': '<(target_subarch)',
'mips_arch_variant%': '<(mips_arch_variant)',
'toolkit_views%': '<(toolkit_views)',
+ 'mac_views_browser': '<(mac_views_browser)',
'desktop_linux%': '<(desktop_linux)',
'use_aura%': '<(use_aura)',
'use_ash%': '<(use_ash)',
@@ -1077,6 +1081,7 @@
'mips_arch_variant%': '<(mips_arch_variant)',
'host_arch%': '<(host_arch)',
'toolkit_views%': '<(toolkit_views)',
+ 'mac_views_browser': '<(mac_views_browser)',
'ui_compositor_image_transport%': '<(ui_compositor_image_transport)',
'use_aura%': '<(use_aura)',
'use_ash%': '<(use_ash)',
@@ -2583,6 +2588,9 @@
['toolkit_views==1', {
'defines': ['TOOLKIT_VIEWS=1'],
}],
+ ['mac_views_browser==1', {
+ 'defines': ['MAC_VIEWS_BROWSER=1'],
tapted 2014/11/04 02:33:42 You might not need this with the comments below
Andre 2014/11/05 02:04:22 Deleted.
+ }],
['ui_compositor_image_transport==1', {
'defines': ['UI_COMPOSITOR_IMAGE_TRANSPORT'],
}],
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_factory.mm » ('j') | chrome/browser/ui/cocoa/browser_window_factory.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698