chrome/browser/ui/BUILD.gn - Issue 697223003: MacViews: Get chrome/browser/ui/views/frame to compile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 697223003: MacViews: Get chrome/browser/ui/views/frame to compile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@constrained

Patch Set: Add DCHECK Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/BUILD.gn

diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn

index 9a15070824dcb5aecdea49534cba84bb2bb2d420..608610c0b2aa3cc4c951ececf74f36dcdf82eea7 100644

--- a/chrome/browser/ui/BUILD.gn

+++ b/chrome/browser/ui/BUILD.gn

@@ -224,7 +224,13 @@ static_library("ui") {

gypi_values.chrome_browser_ui_views_non_chromeos_sources,

".", "//chrome")

}

- if (!is_mac) {

+ if (is_mac) {

+ if (mac_views_browser) {

+ sources -= [ "cocoa/browser_window_factory_cocoa.mm" ]

+ } else {

+ sources -= [ "views/frame/browser_window_factory.cc" ]

+ }

+ } else {

sources += rebase_path(

gypi_values.chrome_browser_ui_views_non_mac_sources,

".", "//chrome")

« no previous file with comments | « build/common.gypi ('k') | chrome/browser/ui/cocoa/browser_window_factory.mm » ('j') | no next file with comments »