Update the ICU's default timezone in render

content/renderer/render_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_thread_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <vector>
@@ skipping 119 matching lines @@
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebImageCache.h"
 #include "third_party/WebKit/public/web/WebKit.h"
 #include "third_party/WebKit/public/web/WebNetworkStateNotifier.h"
 #include "third_party/WebKit/public/web/WebPopupMenu.h"
 #include "third_party/WebKit/public/web/WebRuntimeFeatures.h"
 #include "third_party/WebKit/public/web/WebScriptController.h"
 #include "third_party/WebKit/public/web/WebSecurityPolicy.h"
 #include "third_party/WebKit/public/web/WebView.h"
+#include "third_party/icu/source/i18n/unicode/timezone.h"
 #include "third_party/skia/include/core/SkGraphics.h"
 #include "ui/base/layout.h"
 #include "ui/base/ui_base_switches.h"
 #include "v8/include/v8.h"
 
 #if defined(OS_ANDROID)
 #include <cpu-features.h>
 #include "content/renderer/android/synchronous_compositor_factory.h"
 #include "content/renderer/media/android/renderer_demuxer_android.h"
 #endif
@@ skipping 1538 matching lines @@
       RenderProcessObserver, observers_, NetworkStateChanged(online));
   WebNetworkStateNotifier::setWebConnectionType(
       NetConnectionTypeToWebConnectionType(type));
 }
 
 void RenderThreadImpl::OnTempCrashWithData(const GURL& data) {
   GetContentClient()->SetActiveURL(data);
   CHECK(false);
 }
 
-void RenderThreadImpl::OnUpdateTimezone() {
+void RenderThreadImpl::OnUpdateTimezone(const std::string& zone_id) {
   if (!blink_platform_impl_)
     return;
+  if (!zone_id.empty()) {
+    icu::TimeZone *defaultZone = icu::TimeZone::createTimeZone(
+        icu::UnicodeString::fromUTF8(zone_id));
+    icu::TimeZone::adoptDefault(defaultZone);

[jungshik at Google, 2015/04/10 00:23:44]

adoptDefault() is not thread-safe. If this is called in every thread of
Renderer process, that's a bit problematic (well, we're setting to the same
value, but still it's wasteful to do that multiple times even if there's no
side-effect. TSAN will bark, I guess.)  I wonder if there's a way to call this
only in ONE thread per renderer. 

[jochen (gone - plz use gerrit), 2015/04/10 12:17:24]

can we make it thread safe?

[jungshik at Google, 2015/04/24 22:40:53]

It turned out that I was mistaken about this part. It's called only once per
renderer process afaict. So, I think we don't have to do anything here. 

+    VLOG(0) << "ICU dflt timezone is set to " << zone_id;
+  }
   NotifyTimezoneChange();
 }
 
 #if defined(OS_ANDROID)
 void RenderThreadImpl::OnSetWebKitSharedTimersSuspended(bool suspend) {
   if (suspend_webkit_shared_timer_) {
     EnsureWebKitInitialized();
     if (suspend) {
       blink_platform_impl_->SuspendSharedTimer();
     } else {
@@ skipping 139 matching lines @@
 }
 
 void RenderThreadImpl::PendingRenderFrameConnect::OnConnectionError() {
   size_t erased =
       RenderThreadImpl::current()->pending_render_frame_connects_.erase(
           routing_id_);
   DCHECK_EQ(1u, erased);
 }
 
 }  // namespace content