Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: content/browser/time_zone_monitor.cc

Issue 697203006: Update the ICU's default timezone in render (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/time_zone_monitor.h" 5 #include "content/browser/time_zone_monitor.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/public/browser/browser_thread.h" 8 #include "content/public/browser/browser_thread.h"
9 #include "content/public/browser/render_process_host.h" 9 #include "content/public/browser/render_process_host.h"
10 #include "third_party/icu/source/common/unicode/unistr.h"
11 #include "third_party/icu/source/i18n/unicode/timezone.h"
10 12
11 namespace content { 13 namespace content {
12 14
13 TimeZoneMonitor::TimeZoneMonitor() { 15 TimeZoneMonitor::TimeZoneMonitor() {
14 DCHECK_CURRENTLY_ON(BrowserThread::UI); 16 DCHECK_CURRENTLY_ON(BrowserThread::UI);
15 } 17 }
16 18
17 TimeZoneMonitor::~TimeZoneMonitor() { 19 TimeZoneMonitor::~TimeZoneMonitor() {
18 DCHECK_CURRENTLY_ON(BrowserThread::UI); 20 DCHECK_CURRENTLY_ON(BrowserThread::UI);
19 } 21 }
20 22
21 void TimeZoneMonitor::NotifyRenderers() { 23 void TimeZoneMonitor::NotifyRenderers() {
22 DCHECK_CURRENTLY_ON(BrowserThread::UI); 24 DCHECK_CURRENTLY_ON(BrowserThread::UI);
25 #if defined(OS_CHROMEOS)
26 // On CrOS, ICU's default tz is already set to a new zone. No
27 // need to redetect it with detectHostTimeZone().
28 scoped_ptr<icu::TimeZone> new_zone(icu::TimeZone::createDefault());
29 #else
30 icu::TimeZone* new_zone = icu::TimeZone::detectHostTimeZone();
31 #if defined(OS_LINUX)
32 // We get here multiple times on Linux per a single tz change, but
33 // want to update the ICU default zone and notify renderer only once.
34 scoped_ptr<icu::TimeZone> current_zone(icu::TimeZone::createDefault());
35 if (*current_zone == *new_zone) {
36 VLOG(1) << "timezone already updated";
37 delete new_zone;
38 return;
39 }
40 #endif
41 icu::TimeZone::adoptDefault(new_zone);
42 #endif
43 icu::UnicodeString zone_id;
44 std::string zone_id_str;
45 new_zone->getID(zone_id).toUTF8String(zone_id_str);
46 VLOG(1) << "timezone reset to " << zone_id_str;
23 for (RenderProcessHost::iterator iterator = 47 for (RenderProcessHost::iterator iterator =
24 RenderProcessHost::AllHostsIterator(); 48 RenderProcessHost::AllHostsIterator();
25 !iterator.IsAtEnd(); 49 !iterator.IsAtEnd();
26 iterator.Advance()) { 50 iterator.Advance()) {
27 iterator.GetCurrentValue()->NotifyTimezoneChange(); 51 iterator.GetCurrentValue()->NotifyTimezoneChange(zone_id_str);
28 } 52 }
29 } 53 }
30 54
31 } // namespace content 55 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/common/view_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698