Resume playback of EME stream only on SessionKeysChange event.

Resume playback of EME stream only on SessionKeysChange event.

Now that the CDM is generating SessionKeysChange events, it is no
longer necessary to intercept Update() and Load() promises and
call ResumePlayback() when they are resolved.

BUG=370251, 413413
TEST=existing EME tests pass

Committed: https://crrev.com/5b104332eb9ca3161a69e75ef168c62c765b3e29
Cr-Commit-Position: refs/heads/master@{#302526}

[jrummell, 2014-11-03 21:30:05]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, sandersd@chromium.org

[jrummell, 2014-11-03 21:30:06]

More cleanup.

[sandersd (OOO until July 31), 2014-11-03 21:54:16]

lgtm

Yay!

https://codereview.chromium.org/697203003/diff/1/content/renderer/media/crypt...
File content/renderer/media/crypto/ppapi_decryptor.h (right):

https://codereview.chromium.org/697203003/diff/1/content/renderer/media/crypt...
content/renderer/media/crypto/ppapi_decryptor.h:119: // On an
OnSessionKeysChange event, trigger playback to resume.
"On a SessionKeysChange event..."

[ddorwin, 2014-11-03 22:33:30]

Does this really address those two bugs? Is one dependent on the other?

LGTM with comment.

https://codereview.chromium.org/697203003/diff/1/content/renderer/media/crypt...
File content/renderer/media/crypto/ppapi_decryptor.h (right):

https://codereview.chromium.org/697203003/diff/1/content/renderer/media/crypt...
content/renderer/media/crypto/ppapi_decryptor.h:119: // On an
OnSessionKeysChange event, trigger playback to resume.
On 2014/11/03 21:54:16, sandersd wrote:
> "On a SessionKeysChange event..."

Why does this function comment need to explain when it is called?

Not for this CL, but "AttemptToResumePlayback" is probably a better name. We can
tackle that with some of the related bugs.

[jrummell, 2014-11-03 23:19:29]

Thanks for the reviews.

This should fix 370531, and I included 413413 since the deleted comments
referred to it. It doesn't fix the latter, since that issue is about moving
ResumePlayback() higher in the stack.

https://codereview.chromium.org/697203003/diff/1/content/renderer/media/crypt...
File content/renderer/media/crypto/ppapi_decryptor.h (right):

https://codereview.chromium.org/697203003/diff/1/content/renderer/media/crypt...
content/renderer/media/crypto/ppapi_decryptor.h:119: // On an
OnSessionKeysChange event, trigger playback to resume.
On 2014/11/03 22:33:30, ddorwin wrote:
> On 2014/11/03 21:54:16, sandersd wrote:
> > "On a SessionKeysChange event..."
> 
> Why does this function comment need to explain when it is called?
> 
> Not for this CL, but "AttemptToResumePlayback" is probably a better name. We
can
> tackle that with some of the related bugs.

Removed comment and renamed function.

[jrummell, 2014-11-03 23:19:35]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2014-11-03 23:21:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697203003/20001

[ddorwin, 2014-11-03 23:22:10]

lgtm

[commit-bot: I haz the power, 2014-11-04 00:07:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-04 00:08:30]

Patchset 2 (id:??) landed as
https://crrev.com/5b104332eb9ca3161a69e75ef168c62c765b3e29
Cr-Commit-Position: refs/heads/master@{#302526}