Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 697143005: Fills athena background always. (Closed)

Created:
6 years, 1 month ago by Jun Mukai
Modified:
6 years, 1 month ago
Reviewers:
oshima, mohsen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fills athena background always. BUG=431861 R=oshima@chromium.org, mohsen@chromium.org TEST=manually Committed: https://crrev.com/6a4118079e42983d26074f4b76839da34ae6d6c9 Cr-Commit-Position: refs/heads/master@{#303563}

Patch Set 1 #

Total comments: 2

Patch Set 2 : static method #

Patch Set 3 : visibility changed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -21 lines) Patch
M athena/screen/screen_manager_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M athena/system/background_controller.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M athena/util/fill_layout_manager.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M athena/util/fill_layout_manager.cc View 1 2 2 chunks +21 lines, -4 lines 0 comments Download
M athena/util/fill_layout_manager_unittest.cc View 1 2 1 chunk +36 lines, -15 lines 0 comments Download
M athena/virtual_keyboard/virtual_keyboard_manager_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Jun Mukai
6 years, 1 month ago (2014-11-10 22:04:54 UTC) #1
oshima
https://codereview.chromium.org/697143005/diff/1/athena/util/fill_layout_manager.h File athena/util/fill_layout_manager.h (right): https://codereview.chromium.org/697143005/diff/1/athena/util/fill_layout_manager.h#newcode28 athena/util/fill_layout_manager.h:28: can you add static method static void SetAlwaysFill(aura::Window* window), ...
6 years, 1 month ago (2014-11-10 22:11:49 UTC) #2
Jun Mukai
https://codereview.chromium.org/697143005/diff/1/athena/util/fill_layout_manager.h File athena/util/fill_layout_manager.h (right): https://codereview.chromium.org/697143005/diff/1/athena/util/fill_layout_manager.h#newcode28 athena/util/fill_layout_manager.h:28: On 2014/11/10 22:11:49, oshima wrote: > can you add ...
6 years, 1 month ago (2014-11-10 22:39:02 UTC) #3
oshima
lgtm
6 years, 1 month ago (2014-11-11 00:14:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697143005/40001
6 years, 1 month ago (2014-11-11 00:44:37 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-11 01:28:58 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 01:29:35 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6a4118079e42983d26074f4b76839da34ae6d6c9
Cr-Commit-Position: refs/heads/master@{#303563}

Powered by Google App Engine
This is Rietveld 408576698