Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 697123002: Revert of Add support for GYP_GENERATOR_FLAGS out dir setting for landmines (Closed)

Created:
6 years, 1 month ago by Geoff Lang
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for GYP_GENERATOR_FLAGS out dir setting for landmines (patchset #3 id:40001 of https://codereview.chromium.org/695753002/) Reason for revert: Win8 Release (NVIDIA) and Win8 Debug (NVIDIA) bots are failing to delete temporary files in the hardware_accelerated_feature_tests. Example failed build: http://build.chromium.org/p/chromium.gpu/builders/Win8%20Debug%20%28NVIDIA%29/builds/5655 BUG=429663 Original issue's description: > Add support for GYP_GENERATOR_FLAGS out dir setting for landmines > > BUG=421894 > > Committed: https://crrev.com/6bad0d4fad0ee39e993d90eb2ab8050d650efa2b > Cr-Commit-Position: refs/heads/master@{#302419} TBR=scottmg@chromium.org,skyostil@google.com,skyostil@chromium.org,oetuaho@nvidia.com NOTREECHECKS=true NOTRY=true BUG=421894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M build/landmine_utils.py View 1 chunk +0 lines, -6 lines 0 comments Download
M build/landmines.py View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Geoff Lang
Created Revert of Add support for GYP_GENERATOR_FLAGS out dir setting for landmines
6 years, 1 month ago (2014-11-03 14:50:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697123002/1
6 years, 1 month ago (2014-11-03 14:51:08 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-03 14:51:10 UTC) #4
Sami
I'm not sure how Olli's patch could've caused this. The test is failing because some ...
6 years, 1 month ago (2014-11-03 15:58:18 UTC) #6
Geoff Lang
On 2014/11/03 15:58:18, Sami wrote: > I'm not sure how Olli's patch could've caused this. ...
6 years, 1 month ago (2014-11-03 16:00:57 UTC) #7
oetuaho-nv
Sorry for the breakage, I couldn't foresee this. If manually restoring the bots does not ...
6 years, 1 month ago (2014-11-03 16:06:41 UTC) #8
Geoff Lang
6 years, 1 month ago (2014-11-03 16:42:17 UTC) #9
On 2014/11/03 16:06:41, oetuaho-nv wrote:
> Sorry for the breakage, I couldn't foresee this. If manually restoring the
bots
> does not work, we could also look for whether some scripts used for the bots
set
> GYP_GENERATOR_FLAGS to pinpoint the failure?

Looks like a reboot did the trick.  Release bot is green and I expect the Debug
one to do the same soon.  Closing this revert.

Powered by Google App Engine
This is Rietveld 408576698