Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 697053002: [x86] Fix register constraints for multiply high and modulus. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[x86] Fix register constraints for multiply high and modulus. R=jarin@chromium.org TEST=mjsunit/compiler/regress-register-allocator2 Committed: https://code.google.com/p/v8/source/detail?r=25054

Patch Set 1 #

Patch Set 2 : Add test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +5 lines, -7 lines 0 comments Download
A test/mjsunit/compiler/regress-register-allocator2.js View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 1 month ago (2014-11-03 06:13:40 UTC) #1
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-03 06:15:32 UTC) #2
Jarin
lgtm
6 years, 1 month ago (2014-11-03 06:26:58 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-03 06:27:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25054 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698