Add source generation to GSUtils.download_file.

Add source generation to GSUtils.download_file.

This enables downloading of specific revisions of a file.

Committed: https://skia.googlesource.com/common/+/d7c2e2b9464e70e0f3847a330b930d008dc8c8db

[bungeman-skia, 2014-11-03 23:23:29]

bungeman@google.com changed reviewers:
+ borenet@google.com, rmistry@google.com, stephana@google.com

[bungeman-skia, 2014-11-03 23:23:30]

This is a dependency of https://codereview.chromium.org/688353003/ .

[rmistry, 2014-11-04 12:42:53]

LGTM

https://codereview.chromium.org/697043003/diff/1/py/utils/gs_utils.py
File py/utils/gs_utils.py (right):

https://codereview.chromium.org/697043003/diff/1/py/utils/gs_utils.py#newcode423
py/utils/gs_utils.py:423: source_generation: the generation version of the
source.
Nitiest of nits: Please remove the period (to be consistent with the other
comments in this block.

https://codereview.chromium.org/697043003/diff/1/py/utils/gs_utils.py#newcode428
py/utils/gs_utils.py:428: if (source_generation):
Surrounding parenthesis not needed ->

if source_generation:

[bungeman-skia, 2014-11-04 14:36:47]

https://codereview.chromium.org/697043003/diff/1/py/utils/gs_utils.py
File py/utils/gs_utils.py (right):

https://codereview.chromium.org/697043003/diff/1/py/utils/gs_utils.py#newcode423
py/utils/gs_utils.py:423: source_generation: the generation version of the
source.
On 2014/11/04 12:42:53, rmistry wrote:
> Nitiest of nits: Please remove the period (to be consistent with the other
> comments in this block.

Done.

https://codereview.chromium.org/697043003/diff/1/py/utils/gs_utils.py#newcode428
py/utils/gs_utils.py:428: if (source_generation):
On 2014/11/04 12:42:52, rmistry wrote:
> Surrounding parenthesis not needed ->
> 
> if source_generation: 

Done.

[bungeman-skia, 2014-11-04 14:37:13]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-11-04 14:37:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697043003/20001

[commit-bot: I haz the power, 2014-11-04 14:38:14]

Committed patchset #2 (id:20001) as d7c2e2b9464e70e0f3847a330b930d008dc8c8db