Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 6970004: Introduce lazy sweeping. (Closed)

Created:
9 years, 7 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry, antonm
CC:
v8-dev
Visibility:
Public.

Description

Introduce lazy sweeping. Committed: http://code.google.com/p/v8/source/detail?r=7836

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -106 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/incremental-marking.h View 4 chunks +16 lines, -1 line 0 comments Download
M src/incremental-marking.cc View 8 chunks +106 lines, -72 lines 2 comments Download
M src/incremental-marking-inl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mark-compact.h View 2 chunks +11 lines, -1 line 0 comments Download
M src/mark-compact.cc View 7 chunks +36 lines, -24 lines 1 comment Download
M src/spaces.h View 5 chunks +34 lines, -2 lines 1 comment Download
M src/spaces.cc View 5 chunks +47 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 7 months ago (2011-05-09 16:24:29 UTC) #1
Erik Corry
LGTM http://codereview.chromium.org/6970004/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): http://codereview.chromium.org/6970004/diff/1/src/incremental-marking.cc#newcode154 src/incremental-marking.cc:154: ClearMarkbits(heap_->code_space()); Who clears the mark bits in the ...
9 years, 7 months ago (2011-05-09 21:20:11 UTC) #2
antonm
9 years, 7 months ago (2011-05-10 13:09:38 UTC) #3
DBC

http://codereview.chromium.org/6970004/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):

http://codereview.chromium.org/6970004/diff/1/src/incremental-marking.cc#newc...
src/incremental-marking.cc:242: PrintF("[IncrementalMarking] Start
sweeping.\n");
if (FLAG_trace_incremental_marking)?

Powered by Google App Engine
This is Rietveld 408576698