Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 696983002: Remove Virtual Terminal Manager. (Closed)

Created:
6 years, 1 month ago by kalyank
Modified:
6 years, 1 month ago
Reviewers:
dnicoara, spang
CC:
chromium-reviews, ozone-reviews_chromium.org, nkostylev+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Virtual Terminal Manager. VT is disabled with Freon. VTM is not really needed anymore and thus removing this. Committed: https://crrev.com/f00c0c1c6acf0a3fd650e8c44bfff142b4bd5998 Cr-Commit-Position: refs/heads/master@{#302519}

Patch Set 1 #

Patch Set 2 : Remove Virtual Terminal Manager. #

Patch Set 3 : Remove VT* files from dri/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -117 lines) Patch
M ui/ozone/platform/dri/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 1 3 chunks +1 line, -4 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download
D ui/ozone/platform/dri/virtual_terminal_manager.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
D ui/ozone/platform/dri/virtual_terminal_manager.cc View 1 1 chunk +0 lines, -75 lines 0 comments Download

Messages

Total messages: 15 (2 generated)
kalyank
While trying to set up my development env with Chromium + Ozone-GBM + ChromeOS combination ...
6 years, 1 month ago (2014-11-01 21:43:20 UTC) #2
kalyank
6 years, 1 month ago (2014-11-01 21:43:35 UTC) #3
spang1
instead of creating a flag, let's just remove this code.
6 years, 1 month ago (2014-11-03 15:24:17 UTC) #4
kalyank
On 2014/11/03 15:24:17, spang1 wrote: > instead of creating a flag, let's just remove this ...
6 years, 1 month ago (2014-11-03 17:10:54 UTC) #5
kalyank
On 2014/11/03 17:10:54, kalyank wrote: > On 2014/11/03 15:24:17, spang1 wrote: > > instead of ...
6 years, 1 month ago (2014-11-03 19:25:23 UTC) #6
spang
On 2014/11/03 19:25:23, kalyank wrote: > On 2014/11/03 17:10:54, kalyank wrote: > > On 2014/11/03 ...
6 years, 1 month ago (2014-11-03 22:15:38 UTC) #7
kalyank
On 2014/11/03 22:15:38, spang wrote: > On 2014/11/03 19:25:23, kalyank wrote: > > On 2014/11/03 ...
6 years, 1 month ago (2014-11-03 22:25:36 UTC) #8
dnicoara
On 2014/11/03 22:25:36, kalyank wrote: > On 2014/11/03 22:15:38, spang wrote: > > On 2014/11/03 ...
6 years, 1 month ago (2014-11-03 22:26:56 UTC) #9
kalyank
On 2014/11/03 22:26:56, dnicoara wrote: > On 2014/11/03 22:25:36, kalyank wrote: > > On 2014/11/03 ...
6 years, 1 month ago (2014-11-03 22:47:05 UTC) #10
spang
lgtm
6 years, 1 month ago (2014-11-03 22:48:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696983002/40001
6 years, 1 month ago (2014-11-03 22:50:46 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-03 23:44:43 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 23:45:30 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f00c0c1c6acf0a3fd650e8c44bfff142b4bd5998
Cr-Commit-Position: refs/heads/master@{#302519}

Powered by Google App Engine
This is Rietveld 408576698