Refactoring of DevTools bridge tests: taking advantage of Commands for proxying client-server commu…

Refactoring of DevTools bridge tests: taking advantage of Commands for proxying client-server communication.

Since client and server live on different threads in tests thier communication are proxied. Anounimous classes
are used for that. Since now we have Command's that essentially are call-to-object mapping thay may be used
instead aonymous objects.

BUG=383418
Committed: https://crrev.com/d95b2346c8987cee1eb8d14c861a189eb5be8a01
Cr-Commit-Position: refs/heads/master@{#302599}

[SeRya, 2014-11-03 08:53:58]

Patchset #1 (id:1) has been deleted

[SeRya, 2014-11-03 08:57:23]

serya@chromium.org changed reviewers:
+ mnaganov@chromium.org

[SeRya, 2014-11-03 08:57:24]

PTAL

[mnaganov (inactive), 2014-11-04 02:17:46]

LGTM

https://codereview.chromium.org/696943002/diff/20001/components/devtools_brid...
File
components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/SignalingReceiverProxy.java
(right):

https://codereview.chromium.org/696943002/diff/20001/components/devtools_brid...
components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/SignalingReceiverProxy.java:23:
SignalingReceiver proxee,
I apologize, it looks like I have somehow missed this weird word in previous
interviews. Did you mean a client or a user of a proxy? Can we consider using
"proxyClient" or "proxyUser" then? Not necessarily to fix in this patch, but
worth considering.

[SeRya, 2014-11-04 10:25:27]

https://codereview.chromium.org/696943002/diff/20001/components/devtools_brid...
File
components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/SignalingReceiverProxy.java
(right):

https://codereview.chromium.org/696943002/diff/20001/components/devtools_brid...
components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/SignalingReceiverProxy.java:23:
SignalingReceiver proxee,
On 2014/11/04 02:17:46, mnaganov (cr) wrote:
> I apologize, it looks like I have somehow missed this weird word in previous
> interviews. Did you mean a client or a user of a proxy? Can we consider using
> "proxyClient" or "proxyUser" then? Not necessarily to fix in this patch, but
> worth considering.

|proxee| is a signaling receiver (like DevToolsBridgeServer) that needed to be
accessed on another executor.

Renamed to |server|. I think it's easier to read since it corresponds to
serverExecutor (with is used to execute calls).

[SeRya, 2014-11-04 10:25:39]

The CQ bit was checked by serya@chromium.org

[commit-bot: I haz the power, 2014-11-04 10:26:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696943002/40001

[commit-bot: I haz the power, 2014-11-04 11:12:05]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2014-11-04 11:12:48]

Patchset 2 (id:??) landed as
https://crrev.com/d95b2346c8987cee1eb8d14c861a189eb5be8a01
Cr-Commit-Position: refs/heads/master@{#302599}