Remove the unused push_deps option from the test runners.

Remove the unused push_deps option from the test runners.

BUG=

Committed: https://crrev.com/8574eab93a0defa2e175f6d0e3e0e9802df49899
Cr-Commit-Position: refs/heads/master@{#302494}

[mikecase (-- gone --), 2014-11-01 00:53:54]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, klundberg@chromium.org

[mikecase (-- gone --), 2014-11-01 00:53:54]

The push_deps option was used almost nowhere. In the only place the option was
used (in the host driven tests), the option didn't actually do anything.

I am removing this option from the test runner.

There will be a corresponding downstream change to remove 'push_deps' from a
couple test cases.

https://codereview.chromium.org/696923002/diff/1/build/android/pylib/base/bas...
File build/android/pylib/base/base_test_runner.py (left):

https://codereview.chromium.org/696923002/diff/1/build/android/pylib/base/bas...
build/android/pylib/base/base_test_runner.py:94: logging.warning('Skipping
pushing data to device.')
PushDataDeps is always an empty function except for Instrumentation tests. I
will be moving PushDataDeps to instrumentation/setup.py in a future CL. 

Also, these log statements I'm removing should have probably been inside
PushDataDeps because they appear to be meaningless for anything but
Instrumentation tests. Look at the logs here for example ...
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...

W   11.157s b2bb  Total data: 0.000MB
W   11.157s b2bb  Total data transferred: 0.000MB
W   11.183s 04ae  Pushing data files to device.
W   11.183s 04ae  Total data: 0.000MB
W   11.183s 04ae  Total data transferred: 0.000MB
W   11.416s a2b6  Pushing data files to device.

https://codereview.chromium.org/696923002/diff/1/build/android/pylib/host_dri...
File build/android/pylib/host_driven/test_case.py (left):

https://codereview.chromium.org/696923002/diff/1/build/android/pylib/host_dri...
build/android/pylib/host_driven/test_case.py:60: self.push_deps = False
This line created my only hesitation to remove this push_deps option. However,
push_deps=False would just prevent test_runner.PushDataDeps() from being called
which is an empty function for host driven tests.

[jbudorick, 2014-11-03 15:18:47]

lgtm

https://codereview.chromium.org/696923002/diff/1/build/android/pylib/base/bas...
File build/android/pylib/base/base_test_runner.py (left):

https://codereview.chromium.org/696923002/diff/1/build/android/pylib/base/bas...
build/android/pylib/base/base_test_runner.py:94: logging.warning('Skipping
pushing data to device.')
On 2014/11/01 00:53:54, mikecase wrote:
> PushDataDeps is always an empty function except for Instrumentation tests. I
> will be moving PushDataDeps to instrumentation/setup.py in a future CL. 
> 

In theory, it'd be nice to do this at the same time that we push data deps for
gtests. In practice, this is pretty low priority because of the refactor.

> Also, these log statements I'm removing should have probably been inside
> PushDataDeps because they appear to be meaningless for anything but
> Instrumentation tests. Look at the logs here for example ...
>
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...
> 
> W   11.157s b2bb  Total data: 0.000MB
> W   11.157s b2bb  Total data transferred: 0.000MB
> W   11.183s 04ae  Pushing data files to device.
> W   11.183s 04ae  Total data: 0.000MB
> W   11.183s 04ae  Total data transferred: 0.000MB
> W   11.416s a2b6  Pushing data files to device.

+1

[mikecase (-- gone --), 2014-11-03 20:56:28]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2014-11-03 20:56:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696923002/1

[commit-bot: I haz the power, 2014-11-03 22:05:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-03 22:06:42]

Patchset 1 (id:??) landed as
https://crrev.com/8574eab93a0defa2e175f6d0e3e0e9802df49899
Cr-Commit-Position: refs/heads/master@{#302494}