Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 696913004: Remove HTMLAudioElement. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove HTMLAudioElement. We'll use a Mojo audio API instead. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/08efa5abb2c6b19c4ca0212d20437ffc66a2b850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -146 lines) Patch
M sky/engine/core/core.gni View 2 chunks +0 lines, -3 lines 0 comments Download
D sky/engine/core/html/HTMLAudioElement.h View 1 chunk +0 lines, -50 lines 0 comments Download
D sky/engine/core/html/HTMLAudioElement.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/engine/core/html/HTMLAudioElement.idl View 1 chunk +0 lines, -31 lines 0 comments Download
M sky/engine/core/html/HTMLMediaElement.h View 2 chunks +2 lines, -4 lines 0 comments Download
M sky/engine/core/html/HTMLMediaElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLTagNames.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
lgtm
6 years, 1 month ago (2014-11-04 02:38:39 UTC) #1
esprehn
6 years, 1 month ago (2014-11-04 03:08:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
08efa5abb2c6b19c4ca0212d20437ffc66a2b850.

Powered by Google App Engine
This is Rietveld 408576698