Retrieve font metrics from skia if DirectWrite is enabled for font metrics calculations in the chro…

Retrieve font metrics from skia if DirectWrite is enabled for font metrics calculations in the chrome browser UI.

The previous patch for getting the correct font metrics from DirectWrite https://codereview.chromium.org/692633003/
was wrong as it did not return the correct font metrics in all cases.

Getting the metrics from skia ensures that we get the same font metrics which would be used by skia for rendering.

Changes in this patch are as below:-
1. Removed DirectWrite factory code from PlatformFontWin. The PlatformFontWin::ConvertGDIFontToDirectWriteFont
   function has been replaced by the CreateHFontRefFromSkia function. This function is called if DirectWrite is
   enabled in the browser which sets a static bool on the PlatformFontWin class.

BUG=428645, 427804, 427802
Committed: https://crrev.com/f2d0aaebeb1f0b390b62082f77176ee303942ffb
Cr-Commit-Position: refs/heads/master@{#302547}

[ananta, 2014-11-01 00:30:58]

ananta@chromium.org changed reviewers:
+ scottmg@chromium.org

[ananta, 2014-11-01 00:36:26]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2014-11-01 00:36:26]

+sky

[scottmg, 2014-11-01 00:39:16]

https://codereview.chromium.org/696913002/diff/20001/ui/gfx/platform_font_win.cc
File ui/gfx/platform_font_win.cc (right):

https://codereview.chromium.org/696913002/diff/20001/ui/gfx/platform_font_win...
ui/gfx/platform_font_win.cc:338: paint.setAntiAlias(true);
is there anywhere these can be tied back to where the rendering happens to make
sure they match?

https://codereview.chromium.org/696913002/diff/20001/ui/gfx/platform_font_win...
ui/gfx/platform_font_win.cc:343: const int height =
are all the max(1, ...) necessary? I'm not familiar with cap_height, any
reference for these calculations you could comment here?

https://codereview.chromium.org/696913002/diff/20001/ui/gfx/platform_font_win.h
File ui/gfx/platform_font_win.h (right):

https://codereview.chromium.org/696913002/diff/20001/ui/gfx/platform_font_win...
ui/gfx/platform_font_win.h:164: // Creates and returns a new HFONTRef from the
specified HFONT using metrics
nit; HFONTRef -> HFontRef

[ananta, 2014-11-01 00:56:13]

https://codereview.chromium.org/696913002/diff/20001/ui/gfx/platform_font_win.cc
File ui/gfx/platform_font_win.cc (right):

https://codereview.chromium.org/696913002/diff/20001/ui/gfx/platform_font_win...
ui/gfx/platform_font_win.cc:338: paint.setAntiAlias(true);
On 2014/11/01 00:39:15, scottmg wrote:
> is there anywhere these can be tied back to where the rendering happens to
make
> sure they match?

Used the SystemParametersInfo function on the same lines as the
CachedFontRenderParams class in font_render_params_win.cc.

https://codereview.chromium.org/696913002/diff/20001/ui/gfx/platform_font_win...
ui/gfx/platform_font_win.cc:343: const int height =
On 2014/11/01 00:39:15, scottmg wrote:
> are all the max(1, ...) necessary? I'm not familiar with cap_height, any
> reference for these calculations you could comment here?

This is similar to the CreateHFontRef function which gets these values
from GDI. Added a comment to that effect.

https://codereview.chromium.org/696913002/diff/20001/ui/gfx/platform_font_win.h
File ui/gfx/platform_font_win.h (right):

https://codereview.chromium.org/696913002/diff/20001/ui/gfx/platform_font_win...
ui/gfx/platform_font_win.h:164: // Creates and returns a new HFONTRef from the
specified HFONT using metrics
On 2014/11/01 00:39:15, scottmg wrote:
> nit; HFONTRef -> HFontRef

Cutpasted this from the other functions. Fixed everywhere now.

[scottmg, 2014-11-03 20:31:41]

lgtm

[sky, 2014-11-03 21:59:22]

LGTM

[ananta, 2014-11-04 00:00:14]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-11-04 00:02:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696913002/80001

[commit-bot: I haz the power, 2014-11-04 00:09:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-04 00:09:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ananta, 2014-11-04 00:20:11]

ananta@chromium.org changed reviewers:
+ piman@chromium.org

[ananta, 2014-11-04 00:20:11]

+piman for content owners.

[piman, 2014-11-04 00:28:28]

lgtm

[ananta, 2014-11-04 00:29:21]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-11-04 00:32:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696913002/80001

[commit-bot: I haz the power, 2014-11-04 02:05:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-11-04 02:06:36]

Patchset 5 (id:??) landed as
https://crrev.com/f2d0aaebeb1f0b390b62082f77176ee303942ffb
Cr-Commit-Position: refs/heads/master@{#302547}