Roll buildtools to pull clang-format.

Roll buildtools to pull clang-format.

BUG=428816
NOTRY=true

Committed: https://crrev.com/1c79f864bd63b801f822c3ee0ae0d3fcb65b8e4d
Cr-Commit-Position: refs/heads/master@{#302341}

[Nico, 2014-10-31 22:46:25]

thakis@chromium.org changed reviewers:
+ scottmg@chromium.org

[Nico, 2014-10-31 22:46:25]

this is pretty involved :-/

https://codereview.chromium.org/696843002/diff/20001/.clang-format
File .clang-format (right):

https://codereview.chromium.org/696843002/diff/20001/.clang-format#newcode7
.clang-format:7: # 'int>>' if the file already contains at least one such
instance.)
(i added this since i removed the next line at first, and then re-read the last
bug which reminded me of this)

[scottmg, 2014-10-31 22:55:20]

yes, it's a bit tortured for ~4meg total. Probably should have just checked them
into src/tools/.

(windows toolchain is similarly "great" -- package a zip, upload, get a hash,
put that hash into buildtools, get hash of that commit, and put that into deps.
weeeeee)

https://codereview.chromium.org/696843002/diff/20001/.clang-format
File .clang-format (right):

https://codereview.chromium.org/696843002/diff/20001/.clang-format#newcode7
.clang-format:7: # 'int>>' if the file already contains at least one such
instance.)
On 2014/10/31 22:46:25, Nico wrote:
> (i added this since i removed the next line at first, and then re-read the
last
> bug which reminded me of this)

sorry, should have put a comment last time.

[scottmg, 2014-10-31 22:55:28]

lgtm

[Nico, 2014-10-31 22:56:17]

On 2014/10/31 22:55:20, scottmg wrote:
> yes, it's a bit tortured for ~4meg total. Probably should have just checked
them
> into src/tools/.

i think it used to be simpler, but then jochen wanted to use it in v8 too and
made things all complicated :-/

[scottmg, 2014-10-31 22:56:55]

damnable sharing!

On Fri, Oct 31, 2014 at 3:56 PM, <thakis@chromium.org> wrote:

> On 2014/10/31 22:55:20, scottmg wrote:
>
>> yes, it's a bit tortured for ~4meg total. Probably should have just
>> checked
>>
> them
>
>> into src/tools/.
>>
>
> i think it used to be simpler, but then jochen wanted to use it in v8 too
> and
> made things all complicated :-/
>
>
> https://codereview.chromium.org/696843002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-10-31 22:57:50]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-10-31 22:59:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/696843002/20001

[commit-bot: I haz the power, 2014-10-31 23:00:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-31 23:01:06]

Patchset 2 (id:??) landed as
https://crrev.com/1c79f864bd63b801f822c3ee0ae0d3fcb65b8e4d
Cr-Commit-Position: refs/heads/master@{#302341}