Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 696823002: Fix content scaling bug on Mac (Closed)

Created:
6 years, 1 month ago by ccameron
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix content scaling bug on Mac The root cause was that ImageTransportSurfaceFBO was using the pixel size of the surface to early-out of surface reallocation. This is a problem when scale factor changed and pixel size doesn't -- the change in scale factor is never propagated to the underlying CALayer. Move all logic for changing the size of the surface and for skipping changes in the size of the surface to AllocateOrResizeFramebuffer. Rename ambiguous sizes to be labeled as pixel_size or dip_size. Remove a stray ScopedCAActionDisabler that does nothing (found by inspection of nearby code). Add myself as an OWNER for this path. BUG=424713 Committed: https://crrev.com/712fa19c0fd1757fe041280086bf01f2e5ee3793 Cr-Commit-Position: refs/heads/master@{#302363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -28 lines) Patch
M content/common/gpu/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_calayer_mac.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.h View 3 chunks +5 lines, -4 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.mm View 8 chunks +31 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ccameron
Simple fix.
6 years, 1 month ago (2014-10-31 21:49:59 UTC) #2
Ken Russell (switch to Gerrit)
LGTM, especially your ownership.
6 years, 1 month ago (2014-10-31 23:14:09 UTC) #3
ccameron
Thanks!
6 years, 1 month ago (2014-10-31 23:31:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696823002/1
6 years, 1 month ago (2014-10-31 23:32:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-01 00:14:53 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 00:15:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/712fa19c0fd1757fe041280086bf01f2e5ee3793
Cr-Commit-Position: refs/heads/master@{#302363}

Powered by Google App Engine
This is Rietveld 408576698