Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: sky/specs/apis.md

Issue 696783003: fix the complexity comments for attribute APIs (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/specs/parsing.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/specs/apis.md
diff --git a/sky/specs/apis.md b/sky/specs/apis.md
index ae99eb23b2b15076a95dc38e3d30d97d6e3ec0ee..b7ef4475f036ce4bce30d2fc5ed176e36ae15bd3 100644
--- a/sky/specs/apis.md
+++ b/sky/specs/apis.md
@@ -90,13 +90,13 @@ module 'sky:core' {
abstract class Element : ParentNode {
readonly attribute String tagName; // O(1)
- Boolean hasAttribute(String name); // O(N) in arguments
- String getAttribute(String name); // O(N) in arguments
- void setAttribute(String name, String value = ''); // O(N) in arguments
- void removeAttribute(String name); // O(N) in arguments
+ Boolean hasAttribute(String name); // O(N) in number of attributes
+ String getAttribute(String name); // O(N) in number of attributes
+ void setAttribute(String name, String value = ''); // O(N) in number of attributes
+ void removeAttribute(String name); // O(N) in number of attributes
// Returns a new Array and new Attr instances every time.
- Array<Attr> getAttributes(); // O(N) in arguments
+ Array<Attr> getAttributes(); // O(N) in number of attributes
readonly attribute ShadowRoot? shadowRoot; // O(1) // returns the shadow root
Array<ContentElement> getDestinationInsertionPoints(); // O(N) in number of insertion points the node is in
« no previous file with comments | « no previous file | sky/specs/parsing.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698