Issue 696753003: Subzero: Remove a TODO comment about shld/shrd.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 696753003: Subzero: Remove a TODO comment about shld/shrd. (Closed)

Created:
6 years, 1 month ago by jvoung (off chromium)

Modified:
6 years, 1 month ago

Reviewers:
kschimpf, Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Remove a TODO comment about shld/shrd. The 32-bit validator is now consistent with the 64-bit validator w.r.t. 16-bit shld/shrd and accepts it. We didn't really use the 16-bit form in Subzero though, only the 32-bit one for 64-bit ops, I think. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8835576bd0dce5c2076478d6688762d267babf35

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/IceInstX8632.h	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

jvoung (off chromium)

6 years, 1 month ago (2014-11-01 16:40:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8835576bd0dce5c2076478d6688762d267babf35 (presubmit successful).