Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 696733003: Introduce blink::ServiceProvider (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Introduce blink::ServiceProvider This CL is a warmup for making hyperlinks actually work. ServiceProvider lets the embedder inject a bundle of services that are specific to the embedding context (e.g., NavigatorHost). Services that are independent to the embedding context can be injected via blink::Platform. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1c63e03d2a6a0894e3824ee3aad7da838f0ae10e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -31 lines) Patch
M sky/engine/core/frame/FrameHost.h View 4 chunks +6 lines, -2 lines 1 comment Download
M sky/engine/core/frame/FrameHost.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M sky/engine/core/page/Page.h View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/core/page/Page.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/testing/DummyPageHolder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + sky/engine/platform/exported/ServiceProvider.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
A sky/engine/public/platform/ServiceProvider.h View 1 chunk +24 lines, -0 lines 0 comments Download
M sky/engine/public/web/WebViewClient.h View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.h View 3 chunks +26 lines, -15 lines 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-10-31 17:43:07 UTC) #1
eseidel
lgtm https://codereview.chromium.org/696733003/diff/1/sky/engine/core/frame/FrameHost.h File sky/engine/core/frame/FrameHost.h (right): https://codereview.chromium.org/696733003/diff/1/sky/engine/core/frame/FrameHost.h#newcode71 sky/engine/core/frame/FrameHost.h:71: ServiceProvider* services() const { return m_services; } Why ...
6 years, 1 month ago (2014-10-31 17:48:57 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-10-31 17:54:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c63e03d2a6a0894e3824ee3aad7da838f0ae10e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698