Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 696703005: Remove RenderSelectionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated after Kouhei's comment. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/RenderReplaced.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderObject.cpp
diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp
index aaa9368fc974acd7ea827335978a7220988005a4..c8405195924e131547f1dca9e0c3459187d4f22a 100644
--- a/Source/core/rendering/RenderObject.cpp
+++ b/Source/core/rendering/RenderObject.cpp
@@ -1262,9 +1262,6 @@ void RenderObject::invalidateSelectionIfNeeded(const RenderLayerModelObject& pai
LayoutRect oldSelectionRect = previousSelectionRectForPaintInvalidation();
LayoutRect previousSelectionRectForPaintInvalidation = selectionRectForPaintInvalidation(&paintInvalidationContainer);
- // FIXME: groupedMapping() leaks the squashing abstraction.
- if (paintInvalidationContainer.layer()->groupedMapping())
- RenderLayer::mapRectToPaintBackingCoordinates(&paintInvalidationContainer, previousSelectionRectForPaintInvalidation);
setPreviousSelectionRectForPaintInvalidation(previousSelectionRectForPaintInvalidation);
if (view()->doingFullPaintInvalidation() || isFullPaintInvalidationReason(invalidationReason))
@@ -3006,12 +3003,12 @@ CursorDirective RenderObject::getCursor(const LayoutPoint&, Cursor&) const
return SetCursorBasedOnStyle;
}
-bool RenderObject::canUpdateSelectionOnRootLineBoxes()
+bool RenderObject::canUpdateSelectionOnRootLineBoxes() const
{
if (needsLayout())
return false;
- RenderBlock* containingBlock = this->containingBlock();
+ const RenderBlock* containingBlock = this->containingBlock();
return containingBlock ? !containingBlock->needsLayout() : false;
}
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/RenderReplaced.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698