Remove RenderSelectionInfo

Source/core/rendering/RenderObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 1244 matching lines @@
     selectionPaintInvalidationMap->set(this, selectionRect);
 }
 
 void RenderObject::invalidateSelectionIfNeeded(const RenderLayerModelObject& paintInvalidationContainer, PaintInvalidationReason invalidationReason)
 {
     if (!shouldInvalidateSelection())
         return;
 
     LayoutRect oldSelectionRect = previousSelectionRectForPaintInvalidation();
     LayoutRect previousSelectionRectForPaintInvalidation = selectionRectForPaintInvalidation(&paintInvalidationContainer);
-    // FIXME: groupedMapping() leaks the squashing abstraction.
-    if (paintInvalidationContainer.layer()->groupedMapping())
-        RenderLayer::mapRectToPaintBackingCoordinates(&paintInvalidationContainer, previousSelectionRectForPaintInvalidation);
     setPreviousSelectionRectForPaintInvalidation(previousSelectionRectForPaintInvalidation);
 
     if (view()->doingFullPaintInvalidation() || isFullPaintInvalidationReason(invalidationReason))
         return;
 
     fullyInvalidatePaint(paintInvalidationContainer, PaintInvalidationSelection, oldSelectionRect, previousSelectionRectForPaintInvalidation);
 }
 
 PaintInvalidationReason RenderObject::invalidatePaintIfNeeded(const PaintInvalidationState& paintInvalidationState, const RenderLayerModelObject& paintInvalidationContainer)
 {
@@ skipping 1721 matching lines @@
 
     ASSERT(!node());
     return createPositionWithAffinity(0, DOWNSTREAM);
 }
 
 CursorDirective RenderObject::getCursor(const LayoutPoint&, Cursor&) const
 {
     return SetCursorBasedOnStyle;
 }
 
-bool RenderObject::canUpdateSelectionOnRootLineBoxes()
+bool RenderObject::canUpdateSelectionOnRootLineBoxes() const
 {
     if (needsLayout())
         return false;
 
-    RenderBlock* containingBlock = this->containingBlock();
+    const RenderBlock* containingBlock = this->containingBlock();

[leviw_travelin_and_unemployed, 2014/11/12 23:41:42]

Nit: Is this-> needed?

[Julien - ping for review, 2014/11/13 01:09:32]

It should be: the variable has the same name as the function so C++ (not sure
about C++11) required the this-> to disambiguate the 2.

[kouhei (in TOK), 2014/11/13 01:33:37]

I think this code is a bit tricky.
Would you rename the variable to something else so we can avoid "this->"?

[Julien - ping for review, 2014/11/13 17:03:42]

I don't agree. The code is super straight-forward. The variable name is explicit
and is just a cache of the function's return value (which is why it mirrors the
function name). Finally this is also a fairly common pattern in the code.

[kouhei (in TOK), 2014/11/14 03:11:57]

Got it. lgtm

     return containingBlock ? !containingBlock->needsLayout() : false;
 }
 
 // We only create "generated" child renderers like one for first-letter if:
 // - the firstLetterBlock can have children in the DOM and
 // - the block doesn't have any special assumption on its text children.
 // This correctly prevents form controls from having such renderers.
 bool RenderObject::canHaveGeneratedChildren() const
 {
     return canHaveChildren();
@@ skipping 151 matching lines @@
 {
     if (object1) {
         const blink::RenderObject* root = object1;
         while (root->parent())
             root = root->parent();
         root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
     }
 }
 
 #endif