Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: Source/core/rendering/RenderBlock.h

Issue 696703005: Remove RenderSelectionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated after Kouhei's comment. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 void checkPositionedObjectsNeedLayout(); 247 void checkPositionedObjectsNeedLayout();
248 bool paintsContinuationOutline(RenderInline* flow); 248 bool paintsContinuationOutline(RenderInline* flow);
249 #endif 249 #endif
250 #ifndef NDEBUG 250 #ifndef NDEBUG
251 void showLineTreeAndMark(const InlineBox* = 0, const char* = 0, const Inline Box* = 0, const char* = 0, const RenderObject* = 0) const; 251 void showLineTreeAndMark(const InlineBox* = 0, const char* = 0, const Inline Box* = 0, const char* = 0, const RenderObject* = 0) const;
252 #endif 252 #endif
253 253
254 bool recalcChildOverflowAfterStyleChange(); 254 bool recalcChildOverflowAfterStyleChange();
255 bool recalcOverflowAfterStyleChange(); 255 bool recalcOverflowAfterStyleChange();
256 256
257 virtual LayoutRect selectionRectForPaintInvalidation(const RenderLayerModelO bject* paintInvalidationContainer) const override final;
258
257 protected: 259 protected:
258 virtual void willBeDestroyed() override; 260 virtual void willBeDestroyed() override;
259 261
260 void dirtyForLayoutFromPercentageHeightDescendants(SubtreeLayoutScope&); 262 void dirtyForLayoutFromPercentageHeightDescendants(SubtreeLayoutScope&);
261 263
262 virtual void layout() override; 264 virtual void layout() override;
263 virtual bool updateImageLoadingPriorities() override final; 265 virtual bool updateImageLoadingPriorities() override final;
264 266
265 enum PositionedLayoutBehavior { 267 enum PositionedLayoutBehavior {
266 DefaultLayout, 268 DefaultLayout,
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 // Obtains the nearest enclosing block (including this block) that contribut es a first-line style to our inline 385 // Obtains the nearest enclosing block (including this block) that contribut es a first-line style to our inline
384 // children. 386 // children.
385 virtual RenderBlock* firstLineBlock() const override; 387 virtual RenderBlock* firstLineBlock() const override;
386 388
387 virtual LayoutRect rectWithOutlineForPaintInvalidation(const RenderLayerMode lObject* paintInvalidationContainer, LayoutUnit outlineWidth, const PaintInvalid ationState* = 0) const override final; 389 virtual LayoutRect rectWithOutlineForPaintInvalidation(const RenderLayerMode lObject* paintInvalidationContainer, LayoutUnit outlineWidth, const PaintInvalid ationState* = 0) const override final;
388 390
389 virtual RenderObject* hoverAncestor() const override final; 391 virtual RenderObject* hoverAncestor() const override final;
390 virtual void updateDragState(bool dragOn) override final; 392 virtual void updateDragState(bool dragOn) override final;
391 virtual void childBecameNonInline(RenderObject* child) override final; 393 virtual void childBecameNonInline(RenderObject* child) override final;
392 394
393 virtual LayoutRect selectionRectForPaintInvalidation(const RenderLayerModelO bject* paintInvalidationContainer) const override final
394 {
395 return selectionGapRectsForPaintInvalidation(paintInvalidationContainer) ;
396 }
397 bool isSelectionRoot() const; 395 bool isSelectionRoot() const;
398 GapRects blockSelectionGaps(const RenderBlock* rootBlock, const LayoutPoint& rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock, 396 GapRects blockSelectionGaps(const RenderBlock* rootBlock, const LayoutPoint& rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock,
399 LayoutUnit& lastLogicalTop, LayoutUnit& lastLogi calLeft, LayoutUnit& lastLogicalRight, const PaintInfo*) const; 397 LayoutUnit& lastLogicalTop, LayoutUnit& lastLogi calLeft, LayoutUnit& lastLogicalRight, const PaintInfo*) const;
400 LayoutRect blockSelectionGap(const RenderBlock* rootBlock, const LayoutPoint & rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock, 398 LayoutRect blockSelectionGap(const RenderBlock* rootBlock, const LayoutPoint & rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock,
401 LayoutUnit lastLogicalTop, LayoutUnit lastLogic alLeft, LayoutUnit lastLogicalRight, LayoutUnit logicalBottom, const PaintInfo*) const; 399 LayoutUnit lastLogicalTop, LayoutUnit lastLogic alLeft, LayoutUnit lastLogicalRight, LayoutUnit logicalBottom, const PaintInfo*) const;
402 400
403 // FIXME-BLOCKFLOW: Remove virtualizaion when all callers have moved to Rend erBlockFlow 401 // FIXME-BLOCKFLOW: Remove virtualizaion when all callers have moved to Rend erBlockFlow
404 virtual void clipOutFloatingObjects(const RenderBlock*, const PaintInfo*, co nst LayoutPoint&, const LayoutSize&) const { }; 402 virtual void clipOutFloatingObjects(const RenderBlock*, const PaintInfo*, co nst LayoutPoint&, const LayoutSize&) const { };
405 403
406 virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedO ffset) const override; 404 virtual void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedO ffset) const override;
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 // FIXME: This is temporary as we move code that accesses block flow 492 // FIXME: This is temporary as we move code that accesses block flow
495 // member variables out of RenderBlock and into RenderBlockFlow. 493 // member variables out of RenderBlock and into RenderBlockFlow.
496 friend class RenderBlockFlow; 494 friend class RenderBlockFlow;
497 }; 495 };
498 496
499 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBlock, isRenderBlock()); 497 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBlock, isRenderBlock());
500 498
501 } // namespace blink 499 } // namespace blink
502 500
503 #endif // RenderBlock_h 501 #endif // RenderBlock_h
OLDNEW
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698