Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: Source/core/rendering/RenderBlock.cpp

Issue 696703005: Remove RenderSelectionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated after Kouhei's comment. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderBlock.h ('k') | Source/core/rendering/RenderListMarker.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 235
236 void RenderBlock::destroy() 236 void RenderBlock::destroy()
237 { 237 {
238 RenderBox::destroy(); 238 RenderBox::destroy();
239 #if ENABLE(OILPAN) 239 #if ENABLE(OILPAN)
240 // RenderObject::removeChild called in destory() depends on gColumnInfoMap. 240 // RenderObject::removeChild called in destory() depends on gColumnInfoMap.
241 removeFromGlobalMaps(); 241 removeFromGlobalMaps();
242 #endif 242 #endif
243 } 243 }
244 244
245 LayoutRect RenderBlock::selectionRectForPaintInvalidation(const RenderLayerModel Object* paintInvalidationContainer) const
246 {
247 LayoutRect rect = selectionGapRectsForPaintInvalidation(paintInvalidationCon tainer);
248 // FIXME: groupedMapping() leaks the squashing abstraction.
249 if (paintInvalidationContainer->layer()->groupedMapping())
250 RenderLayer::mapRectToPaintBackingCoordinates(paintInvalidationContainer , rect);
251 return rect;
252 }
245 void RenderBlock::willBeDestroyed() 253 void RenderBlock::willBeDestroyed()
246 { 254 {
247 // Mark as being destroyed to avoid trouble with merges in removeChild(). 255 // Mark as being destroyed to avoid trouble with merges in removeChild().
248 m_beingDestroyed = true; 256 m_beingDestroyed = true;
249 257
250 // Make sure to destroy anonymous children first while they are still connec ted to the rest of the tree, so that they will 258 // Make sure to destroy anonymous children first while they are still connec ted to the rest of the tree, so that they will
251 // properly dirty line boxes that they are removed from. Effects that do :be fore/:after only on hover could crash otherwise. 259 // properly dirty line boxes that they are removed from. Effects that do :be fore/:after only on hover could crash otherwise.
252 children()->destroyLeftoverChildren(); 260 children()->destroyLeftoverChildren();
253 261
254 // Destroy our continuation before anything other than anonymous children. 262 // Destroy our continuation before anything other than anonymous children.
(...skipping 4155 matching lines...) Expand 10 before | Expand all | Expand 10 after
4410 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Render Object* obj) const 4418 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Render Object* obj) const
4411 { 4419 {
4412 showRenderObject(); 4420 showRenderObject();
4413 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box()) 4421 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box())
4414 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1); 4422 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1);
4415 } 4423 }
4416 4424
4417 #endif 4425 #endif
4418 4426
4419 } // namespace blink 4427 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBlock.h ('k') | Source/core/rendering/RenderListMarker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698