Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 696703002: Follow up to fix v8::Exception::GetMessage() actually do what it was intended to. (Closed)

Created:
6 years, 1 month ago by aandrey
Modified:
6 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Follow up to fix v8::Exception::GetMessage() actually do what it was intended to. The main thing for v8::Exception::GetMessage() is to extract message location from error stack trace, even when stack trace capturing is off (when DevTools is closed). BUG=chromium:427954 R=yangguo@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=25101

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -12 lines) Patch
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 4 chunks +9 lines, -9 lines 1 comment Download
M test/cctest/test-api.cc View 3 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
aandrey
6 years, 1 month ago (2014-10-31 15:11:56 UTC) #1
aandrey
https://codereview.chromium.org/696703002/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/696703002/diff/1/src/isolate.cc#newcode1162 src/isolate.cc:1162: if (!ComputeLocationFromStackTrace(&potential_computed_location, this was under the (capture_stack_trace_for_uncaught_exceptions_) flag, which ...
6 years, 1 month ago (2014-10-31 15:13:55 UTC) #2
aandrey
Blink side change: https://codereview.chromium.org/693183002/
6 years, 1 month ago (2014-10-31 16:34:38 UTC) #3
Yang
On 2014/10/31 16:34:38, aandrey wrote: > Blink side change: https://codereview.chromium.org/693183002/ lgtm.
6 years, 1 month ago (2014-11-03 12:22:33 UTC) #5
aandrey
6 years, 1 month ago (2014-11-04 10:06:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25101 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698